Re: [Lcd4linux-devel] Compile error since revision 1082

[Mattia Jona-L. <mat...@gm...>]

Hi Martin,

It definitely makes sense. Though it would be even better to put it in
some general header
like plugin.h. The configuration is not something "per plugin". Since
all plugins include plugin.h,
config.h would be included automatically in a natural way.

In the same spirit it would make sense to put an include config.h in
drv.h and widget.h.

But this is, of course, a matter of taste.

Bye!

Mattia


On Tue, Jan 19, 2010 at 1:31 PM, Martin Zuther <co...@mz...> wrote:
> Hi Mattia,
>
> thanks!  You're right, "lcd4linux" compiles as a charm after making the
> change, and I have already committed this to SVN.  Moreover, I have
> looked through the other plugins to made sure that all of them include
> "config.h".  (They do. <g>)
>
> Do you think it would make sense to change "plugin_sample.c" from
>
>   /* define the include files you need */
>   #include "config.h"
>
>   #include <stdlib.h>
>   #include <string.h>
>   #include <ctype.h>
>
>   /* these should always be included */
>   (...)
>
> to
>
>   /* this file should always be included */
>   #include "config.h"
>
>   /* define the include files you need */
>   #include <stdlib.h>
>   #include <string.h>
>   #include <ctype.h>
>
>   /* these should always be included */
>   (...)
>
> In this way, everybody would see that "config.h" shouldn't be removed.
>
> Martin
> --
> www.mzuther.de
> www.radix-musik.de
>
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> _______________________________________________
> Lcd4linux-devel mailing list
> Lcd...@li...
> https://lists.sourceforge.net/lists/listinfo/lcd4linux-devel
>