Thread: [Lcd4linux-devel] [PATCH] Disable Sample driver if usb.h isn't available

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

This patch does $subject. It's needed in case you don't want to modify
--drivers options.

Hi Fox,

> This patch does $subject. It's needed in case you don't want to modify
> --drivers options.

Thanks for your contribution. I will slightly modify it, to work on
configure.in (and not configure which is built automagically).

But I'm afraid I don't understand the reason for your patch: *why* do
you want to disable the sample driver in case of no libusb available? Is
there a problem?

TIA, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781

Hi michael,

> But I'm afraid I don't understand the reason for your patch: *why* do
> you want to disable the sample driver in case of no libusb available? Is
> there a problem?

I'm a developper for the GeeXboX project, and we use lcd4linux to
display mplayer informations on the lcd display. GeeXboX has its own
toolchain that doesn't include usb stuffs, and I get an error when
compiling it with the Sample driver enable. My patch fixes this issue,
but it could be good to have more reports about this.
BTW i plan to send you my mplayer plugin, as soon as I have sent the
corresponding patch to mplayer devlist. As this mod assumes patching
both mplayer and lcd4linux, I need the 2 projects to be aware of my
work.

Hi FoX,

>> But I'm afraid I don't understand the reason for your patch: *why* do
>> you want to disable the sample driver in case of no libusb available? Is
>> there a problem?
> 
> I'm a developper for the GeeXboX project, and we use lcd4linux to
> display mplayer informations on the lcd display.
Cool!

> GeeXboX has its own
> toolchain that doesn't include usb stuffs, and I get an error when
> compiling it with the Sample driver enable. My patch fixes this issue,
> but it could be good to have more reports about this.

Thanks for the hint, I've found the bug: drv_Sample.c used to #include
<usb.h>, which doesn't make too much sense.. I removed it and commited
to CVS.

> BTW i plan to send you my mplayer plugin, as soon as I have sent the
> corresponding patch to mplayer devlist. As this mod assumes patching
> both mplayer and lcd4linux, I need the 2 projects to be aware of my
> work.
Great!

If there's something up and running, would you mind adding some stuff to
the wiki?

bye, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781

Thread: [Lcd4linux-devel] [PATCH] Disable Sample driver if usb.h isn't available

lcd4linux-devel