lcd4linux-devel

[Lcd4linux-devel] Plugin MySQL: rename of functions

[Michael R. <re...@eu...>]

Hi there,

yesterday I got a patch from Harald Klemm which adds a new function
'queryvalue()' to the MySQL Plugin. This new function returns the first
value of a query.

Now, I think the function names are a bit misleading: query() returns
the number of rows returned by a query; queryvalue a real value.

I think queryvalue() should be renamed to query(), and the current query
function to 'count()' or something....


any comments? Who feels "responsible" for the MySQL Plugin?

TIA, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781

[Lcd4linux-devel] Re: [lcd4linux] Plugin MySQL: rename of functions

[Harald K. <HK...@ta...>]

Hi Michi.!

> I think queryvalue() should be renamed to query(), and the current query
> function to 'count()' or something....
I think the function 'count' ist not necessarily, you can make the same with
an SQL-Query like this :

select count(*) from whos_online;

this will also return the number of rows from the SQL-query.

BYe
   Harald

---
http://EmptySoft.net

[Lcd4linux-devel] Re: [lcd4linux] Plugin MySQL: rename of functions

[Michael R. <re...@eu...>]

Hi there,

>>I think queryvalue() should be renamed to query(), and the current query
>>function to 'count()' or something....
> 
> I think the function 'count' ist not necessarily, you can make the same with
> an SQL-Query like this :
> 
> select count(*) from whos_online;
> 
> this will also return the number of rows from the SQL-query.


Very good point! As nobody complained, I'm going to change this, remove
query() and rename queryValue() to query.

bye, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781

Re: [Lcd4linux-devel] Re: [lcd4linux] Plugin MySQL: rename of functions

[Javi <ja...@gs...>]

=2D----- El Viernes, 20 de Enero de 2006 16:37, Michael Reinelt escribi=F3:=
 ------
> Hi there,
>=20
> >>I think queryvalue() should be renamed to query(), and the current query
> >>function to 'count()' or something....
> >=20
> > I think the function 'count' ist not necessarily, you can make the same=
 with
> > an SQL-Query like this :
> >=20
> > select count(*) from whos_online;
> >=20
> > this will also return the number of rows from the SQL-query.
>=20
>=20
> Very good point! As nobody complained, I'm going to change this, remove
> query() and rename queryValue() to query.
>=20
> bye, Michael
>=20
As a suggestion, I'd rename current query() to queryNumRows() or similar.

Rgrds.

Re: [Lcd4linux-devel] Re: [lcd4linux] Plugin MySQL: rename of functions

[Michael R. <re...@eu...>]

Hi Javi,

>>Very good point! As nobody complained, I'm going to change this, remove
>>query() and rename queryValue() to query.

> As a suggestion, I'd rename current query() to queryNumRows() or similar.

Another good point. Added again, and renamed to MySQL::count(). Checked
into CVS.


Thanks, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781