Thread: [Lcd4linux-devel] i2c_sensors broken :/

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hello Michael !

With your last commit, you broke plugin_i2c_sensors ! It seems like
qprintf doesn't work as expected. I'll try to work on it.

Bye !
-- 
Xavier VELLO <xav...@fr...>

hI xAVIER,
> With your last commit, you broke plugin_i2c_sensors ! It seems like
> qprintf doesn't work as expected. I'll try to work on it.

Sorry. You're right, qprintf() does not support %f (float/double numbers).

We could either replace with snprintf() or enhance qprintf() for floats.

bye, Michael

-- 
Michael Reinelt                                   Tel: +43 676 3079941
Geisslergasse 4                                   Fax: +43 316  692343
A-8045 Graz, Austria                          e-mail: re...@eu...

Hi Xavier,

>> With your last commit, you broke plugin_i2c_sensors ! It seems like
>> qprintf doesn't work as expected. I'll try to work on it.
> 
> Sorry. You're right, qprintf() does not support %f (float/double numbers).
> 
> We could either replace with snprintf() or enhance qprintf() for floats.

I just browsed through the manuals: There are these ecvt(), fcvt, gcvt() 
functions which convert a float/double into a string. But they are "not 
recommended", one should use sprintf() instead.

So I won't rework qprintf(), it should be used for strings and integers 
only.

We have to replace the call to qprintf() with snprintf in the 
i2c_sensors plugin.

Xavier, will you, or shall I do so?

bye, Michael

-- 
Michael Reinelt                                   Tel: +43 676 3079941
Geisslergasse 4                                   Fax: +43 316  692343
A-8045 Graz, Austria                          e-mail: re...@eu...

> With your last commit, you broke plugin_i2c_sensors ! It seems like
> qprintf doesn't work as expected. I'll try to work on it.

I found the problem ! qprintf doesn't work with float ! Maybe you can
write support for %f in qprintf, but for the moment, we should put back
sprintf, patch included.

PS: I dislike the fact to have *LCD4Linux* written on my LCD when L4L is
killed, I'd rather have a blanck screen. Conf option ?

Bye !
-- 
Xavier VELLO <xav...@fr...>

Hi Xavier,

> I found the problem ! qprintf doesn't work with float ! Maybe you can
> write support for %f in qprintf, but for the moment, we should put back
> sprintf, patch included.

applied, but with a change: I used snprintf() rather than sprintf.

> PS: I dislike the fact to have *LCD4Linux* written on my LCD when L4L is
> killed, I'd rather have a blanck screen. Conf option ?
There is one, called "quiet", same as -q

Works with startup splash screen, seems not to work with exit splash 
screen. I will fix this.

bye, Michael

-- 
Michael Reinelt                                   Tel: +43 676 3079941
Geisslergasse 4                                   Fax: +43 316  692343
A-8045 Graz, Austria                          e-mail: re...@eu...

Thread: [Lcd4linux-devel] i2c_sensors broken :/

lcd4linux-devel