lcd4linux-devel

[Lcd4linux-devel] [PATCH] Add strftime_tz()

[Bernhard W. <ber...@gm...>]

Hi,

here's a patch that adds strftime_tz() that allows as 3rd argument a
time zone string (like "Europe/Berlin" or "UTC").

This allows to build a World Time Clock with lcd4linux. :-)

If you think that the patch is okay, I'll add documentation to the Wiki
in https://ssl.bulix.org/projects/lcd4linux/wiki/plugin_time.


Signed-off-by: Bernhard Walle <ber...@gm...>

Re: [Lcd4linux-devel] [PATCH] Add strftime_tz()

[Michael R. <mi...@re...>]

Hi Bernhard,

> here's a patch that adds strftime_tz() that allows as 3rd argument a
> time zone string (like "Europe/Berlin" or "UTC").

Great! Thanks a lot, applied and committed!


bye, Michael

-- 
Michael Reinelt <mi...@re...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781

Re: [Lcd4linux-devel] [PATCH] Add strftime_tz()

[Dirk J. <do...@cu...>]

Hello Bernhard et al,

nice patch, but the getenv() function only returns a pointer into the
environment buffer, not a copy. So the next setenv() call might
overwrite the old value of TZ. I've modified your patch to preserve a
copy of the old value. (Please note, that I have not tested this
modified patch I merely edited it directly.)

-- 
---> Dirk Jagdmann
----> http://cubic.org/~doj
-----> http://llg.cubic.org

Re: [Lcd4linux-devel] [PATCH] Add strftime_tz()

[Bernhard W. <ber...@bw...>]

* Dirk Jagdmann <do...@cu...> [2008-09-08]: 

> nice patch, but the getenv() function only returns a pointer into the
> environment buffer, not a copy. So the next setenv() call might
> overwrite the old value of TZ. I've modified your patch to preserve a
> copy of the old value. (Please note, that I have not tested this
> modified patch I merely edited it directly.)

Hi,

ah, yes, you're absolutely right. Sorry for the mistake. Michael,
should I come with a fix against current SVN trunk?


Bernhard