#49 JVCL no more compile on cleanslate Lazarus

[Burov Dmitry]

fpcupdeluxe win64 / stable / stable

jcl is compiled form git

trying to install jvcl i see

(3104) Compiling D:\fpcupdeluxe\ccr\jvcl\run\JvCore\jvjvclutils.pas
D:\fpcupdeluxe\ccr\jvcl\run\JvCore\jvjvclutils.pas(1210,13) Error: (5000) Identifier not found "ColorToHSV"
D:\fpcupdeluxe\ccr\jvcl\run\JvCore\jvjvclutils.pas(1221,13) Error: (5000) Identifier not found "ColorToHSV"
D:\fpcupdeluxe\ccr\jvcl\run\JvCore\jvjvclutils.pas(1232,13) Error: (5000) Identifier not found "ColorToHSV"

[wp]

Please be more specific. What are your Lazarus and fpc versions? And which jvcl version are you talking about: trunk or release (from OPM)?

Assuming that "stable/stable" means Laz 2.0.12 and FPC 3.20, respectively, and that jvcl is the OPM version I tried to compile the 64-bit version for windows - no problem at all.

[Burov Dmitry]

i am just doing clean re-install, as fpcupdeluxe managed to totally break IDE building, so can not check versions ATM. Both jcl and jvcl were also instaleld via fpcupdeluxe

--------------- okay ----

Lazarus 2.0.12 r64642 FPC 3.2.2 x86_64-win64-win32/win64

jcl seems t be latest github version:

Ревизия: 3047f7eb64804a630086f98d3eda23294aec9178
Автор: obones 
Дата: 10.11.2021 18:58:22

jvcl seems to be CCR SVN

Revision: 8074
Author: wp_xxyyzz
Date: 15 августа 2021 г. 1:25:04
Message:
jvcllaz: Port color component extraction routines in JvJVCLUtils.
----
Modified : /components/jvcllaz/run/JvCore/jvjvclutils.pas

==========

Problem is that neither JCL nor JVCL seems ot have declaration for ColorToHSV function.

I have an old box with Delphi XE2 and semi-forked JCL/JVCL (of 2014), and there were procedure RGBToHSV(R, G, B: Integer; var H, S, V: Integer); in both JvJCLtils and JvJVCLUtils (probably remains of RxLib)

I did grep over *.pas and *.pp in the whole d:\fpcupdeluxe folder - and the only occurence of ColorToHSV is in the jvjvclutils.pas

Where do you take the declaration of it from ?

[wp]

You do not need JCL for the Lazarus port of JVCL.

But I see the issue now. The problem arose because Laz 2.0.x's GraphUtils unit does not yet contain the ColorToHSV function. Should be fixed now.

[Burov Dmitry]

Do you have any control of how fpcupdeluxe presents jvcl? Currently it is just mere "JEDI VCL Code Library for FPC and Lazarus."

If this port does not require vanilla JCL, and perhaps can even be interferring with it - it better be said in description.

[wp]

Sorry, I don't have any control over fpcupdeluxe. I even don't know if it uses "my" port - maybe there's another one out there... Contact DonAlfredo and refer to this report.

[Burov Dmitry]

It does use SF CCR, i ended here by finding out the active SVN link from local sources :-)

[wp]

And where does it get JCL from? I cannot imagine that the version in the original github for Delphi would even compile for Lazarus, at least not in a cross-platform manner.

[Burov Dmitry]

JCL was always more compatible than JVCL. And it always kept FPC compatibility.

JVCL was having Delphi 5 lowest bar, when i was involved (and one more percon mantained C++Builder 5 quirks after me). When i jumped out - they found no other D5 maintainer, and while some outcries of "customers" were in NNTP forum, but none of them picked the ball. So, JVCL started to require Delphi 7.

Back then, if my memory is ok, JCL started with Dephi 4, and it remained so after i left JVCL boat.

That sis reasonable though. VCL i not LCL and is very tightly bound to Windows GDI API. JCL is more or less generic thing, but VCL is all about Win32. JCL was and still is Delphi+FPC and GUI-less, VCL and JVCL always were Delphi-Windows-only.

[wp]

Did my commit fix the issue?

[Burov Dmitry]

Seems so. The mistake was obvious so was the fix.

I did not try yet actually to use Laz, but at leastthe installation sequence in fpcupdeluxe went OK.

However the whole "smoothness" of fpcupdeluxe makes me want to move back to CodeTyphon...