Re: [Lapackpp-devel] committed files

[Christian S. <sti...@tu...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Dominik,

thanks a lot for your contributions. By now I've reviewed all of them
and commited them into CVS. In blas3pp.{h,cc} I've replaced the "char"
argument back to "bool" just as I proposed before.

Dominik Wagenfuehr schrieb:
> Attached you find a corrected version fo blas3pp.cc (There were some
> errors in it, sorry for that!) and a test case tsybmd.cc for
> LaSymmBandMatDouble and LaSymmBandFactDouble. The classes were correct
> only my example was wrong. ;)

In this mail from 11:06 Uhr you attached a file blas3pp.cc that was
identical to the CVS version of that file at that time, not one with
some errors fixed. I've committed your file of yesterday into CVS. If
there are still errors, feel free to send me an updated / corrected
version now.

> Another question: doxygen does not show the new comments in blas3pp.h
> because of the #ifdef before. What do we do here?

There doesn't seem to be an easy solution in terms of doxygen commands.
However, these whole functions don't need to have the full class
definition of LaSymmMatDouble available - it is sufficient for the
compiler to have a forward declaration of those classes only. Therefore
I've removed the ifdef that asks for the included header, and instead
I've added the appropriate forward declaration. As a nice side effect,
this solved the doxygen issues as well.

Christian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBRWLu92XAi+BfhivFAQK5oQP/TkizqagPUKTooN1n44wgAREaMCK1s3i8
8omwkJVgujk54GiQsw+DTUun1YV1SYlfh9I+H+aolAE9bcWAQH7I7DBi8SoDO1h+
hmcakLyJb4hN+cV7yPrGzkMN/6nAUbwKisDlTkYnXL6KMDggX0FQJTEVi/rQOg3p
o86MA1+Utsc=
=1FGS
-----END PGP SIGNATURE-----