Menu

#79 Wrong wave parsing

None
closed
None
5
2018-03-17
2017-12-30
Elio Blanca
No

When built without libsndfile, lame does internal wave parsing.
In case of wave files with data chunk > 2 GB, the current 32bit parsing routine wrongly return a negative number (it reads a two's complement number) so the number of samples is wrong. In turn, this causes the total frame number estimation to be wrong (<0) and the encoding histogram never shows the total frame progress.
The attached patch fixes this.

1 Attachments

Discussion

  • Robert Hegemann

    Robert Hegemann - 2018-01-03

    let me guess. you are talking about 64 bit compiles?

     
    • Elio Blanca

      Elio Blanca - 2018-01-03

      Yes I am, on x86 debian this bug doesn't appear.

       
  • Elio Blanca

    Elio Blanca - 2018-02-06

    Anyway, I see your latest commit r6426 fixed this bug.
    This ticket may be closed.

     
  • Robert Hegemann

    Robert Hegemann - 2018-03-17
    • status: open --> closed
    • assigned_to: Robert Hegemann
    • Group: -->
     
  • Robert Hegemann

    Robert Hegemann - 2018-03-17

    Thanks for pointing out this issue!

     

Log in to post a comment.