#34 [PATCH] 'make all' borked with recent CVS changes

closed
nobody
libmp3lame (13)
5
2006-12-20
2006-11-27
Sci_Fi
No

Hi,

Did a cvs up and now we get this during make all:

[...]
if /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -I. -I../mpglib -I.. -O3 -ffast-math -funroll-loops -fschedule-insns2 -fbranch-count-reg -fforce-addr -fforce-mem -Wall -fno-common -MT lame.lo -MD -MP -MF ".deps/lame.Tpo" -c -o lame.lo lame.c; \ then mv -f ".deps/lame.Tpo" ".deps/lame.Plo"; else rm -f ".deps/lame.Tpo"; exit 1; fi
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -I. -I../mpglib -I.. -O3 -ffast-math -funroll-loops -fschedule-insns2 -fbranch-count-reg -fforce-addr -fforce-mem -Wall -fno-common -MT lame.lo -MD -MP -MF .deps/lame.Tpo -c lame.c -fno-common -DPIC -o .libs/lame.o
lame.c: In function 'lame_encode_buffer_sample_t':
lame.c:1627: warning: passing argument 3 of 'fill_buffer' from incompatible pointer type
lame.c: In function 'lame_mp3_tags_fid':
lame.c:2099: error: too many arguments to function 'PutVbrTag'
make[3]: *** [lame.lo] Error 1
make[3]: Leaving directory `/Volumes/MaxFire3/Projects/lame_cvs/lamefresh/libmp3lame'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/Volumes/MaxFire3/Projects/lame_cvs/lamefresh/libmp3lame'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/Volumes/MaxFire3/Projects/lame_cvs/lamefresh'
make: *** [all] Error 2
make: Leaving directory `/Volumes/MaxFire3/Projects/lame_cvs/lamefresh'

I think line 2099 in lame.c got missed with the recent changes; the attached simple patch fixed it for me and the rest compiled fine (not tested yet). ;) This ought to be a common problem on most platforms and configs, but fwiw:

# uname -a
Darwin (nottelling) 8.8.0 Darwin Kernel Version 8.8.0: Fri Sep 8 17:18:57 PDT 2006; root:xnu-792.12.6.obj~1/RELEASE_PPC Power Macintosh powerpc PowerMac7,3 Darwin

# gcc --version
powerpc-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, Inc. build 5367)

Thanks...

Discussion

  • Sci_Fi

    Sci_Fi - 2006-11-27

    remove 3rd parm in PutVbrTag call in lame.c to match recent cvs changes

     
  • Robert Hegemann

    Robert Hegemann - 2006-12-20
    • status: open --> closed
     
  • Robert Hegemann

    Robert Hegemann - 2006-12-20

    Logged In: YES
    user_id=1106
    Originator: NO

    It should work again.

     

Log in to post a comment.