From: Takehiro T. <tak...@in...> - 2002-10-15 15:31:25
|
>>>>> "R" == Robert Hegemann <Rob...@gm...> writes: R> some remarks: does not compile on Win32 R> FLOAT_MAX isn't defined in psymodel.c uuuuum.... FLOAT_MAX is defined in machine.h. This is same as the mainline. #if ( defined(_MSC_VER) || defined(__BORLANDC__) || defined(__MINGW32__) ) # define WIN32_LEAN_AND_MEAN # include <windows.h> #else # ifndef FLOAT typedef float FLOAT; # ifdef FLT_MAX # define FLOAT_MAX FLT_MAX # else # define FLOAT_MAX 1e99 /* approx */ # endif # endif #endif But I think this is completely screwed up. 1. if FLOAT is float, FLOAT_MAX should be arround 1e37, not 1e99. 2. on a Windows environment, it seems <windows.h> does not define the FLOAT_MAX. so I think the code should be #if ( defined(_MSC_VER) || defined(__BORLANDC__) || defined(__MINGW32__) ) # define WIN32_LEAN_AND_MEAN # include <windows.h> #endif #ifndef FLOAT typedef float FLOAT; # ifdef FLT_MAX # define FLOAT_MAX FLT_MAX # else # define FLOAT_MAX 1e37 /* approx */ # endif #endif I commited this change in my experimental branch. Could someone can check this ? -- Takehiro TOMINAGA // may the source be with you! |