[Lame-dev] strict ISO complience

[Mark T. <mt...@su...>]

> 
> Message: 1
> Reply-To: "Gabriel Bouvigne" <bou...@mp...>
> From: "Gabriel Bouvigne" <bou...@mp...>
> To: <Lam...@li...>
> Date: Thu, 19 Apr 2001 22:27:29 +0200
> Subject: [Lame-dev] strict iso compliance
> 
> http://pub41.ezboard.com/fr3mixfrm1.showMessage?topicID=614.topic
> >From the above link, we now have a report of a user using 3.86 for 256 and
> 320 cbr and who encountered problems.
> He's using a NAD C660 CD player which uses a Cirrus Logic dsp for decoding.
> On this player, he encountered some pops and clicks.
> I asked him to try adding --striclty-enforce-iso, and this solved his
> problem.
> 
> We now have an example of a problem with relaxed iso.
> If there is no objection against it in a week, I'll default this switch.
> 

Gabriel,

Do you think the user would be willing to do some further tests?

It is this code in reservoir.c:

    /* maximum allowed frame size */
    maxmp3buf = (gfp->strict_ISO) ? 8*960 : 8*2047;

The value of 960 is in my opinion much too restrictive,
as evidenced by the fact that all software decoders seem to
have no problems if this value is as large as 2047.  

For VBR/ABR mode, everytime it uses a 320kbs frame, strict_ISO
forces us to zero out the reservoir and thus waste bits.

Maybe the user could try a few values between 960 and 2047?

Mark