From: robert <Rob...@gm...> - 2008-08-29 09:01:23
|
Am 29.08.2008, 08:58 Uhr, schrieb Rogério Brito <rb...@im...>: > Hi, Robert. > > On 28/08/2008, at 18:11, robert wrote: > >> Am 25.08.2008, 15:20 Uhr, schrieb Rogério Brito <rb...@us...>: >>> I committed the patches that Sebastian made us aware and they are >>> already >>> on the lame3_98 branch. >>> >>> I will commit them to the HEAD branch soon. >> >> It looks like the PIC patches are some ELF-only working patches. >> Assembling on Win32 is now broken, MacOS maybe too. > > Yes, MacOS X uses the mach-o object file types. Can you tell me if > changing the > > %ifidn __OUTPUT_FORMAT__,elf > > from /lame/libmp3lame/i386/nasm.h to > > %ifdef LINUX > > gets back it working under win32? If Alexander can test it also, it > would be fine (even though I suspect that FreeBSD uses ELF binaries). > > BTW, excuse my ignorance of Windows-land, but which compiler do you > use under Windows? I know next to nothing about Windows (the last > Windows that I used was Windows 3.11, IIRC). This way, I can test the > changes that I make on one more environment (I had tested it on Linux > with both the patch and without it). > > > Regards, Rogério Brito. > Your mentioned change will not work. Here are some error messages: Assembling fft3dn... c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:41: error: symbol `..gotpc' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:45: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:55: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:136: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:146: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:261: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:285: error: symbol `..gotpc' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:289: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:299: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:364: error: symbol `..gotoff' undefined c:\cvs\lame-main-branch\libmp3lame\i386\fft3dn.nas:478: error: symbol `..gotoff' undefined (null):16777309: error: phase error detected at end of assembly. Those obscure things ..gotpc and ..gotoff seem to be defined for ELF only. I'm not sure FreeBSD uses ELF, maybe AOUTB? At least, looking into nasm.h: ; for Windows Visual C++ -> define WIN32 ; Borland or cygwin -> WIN32 and COFF ; for FreeBSD 2.x -> AOUT ; for TownsOS -> __tos__ ; otherwise -> none Ciao Robert |