#16 Patch to make name lookup for listening points optional
Patch to make name lookup for incoming connections an option of listen().
This change listen() syntax and listeners() output consequently.
The new syntax for listen() is:
listen(OBJ <object>, ANY <point> [, LIST <options>])
Where <options> is a list of pairs {STR <option name>, ANY <option value>}
Two options are recognized by this patch:
"print-messages" as per the optional argumen to listen() in 1.8.1 and earlier versions.
"name-lookup" if set to false, there won't be any name lookup on incoming connections for that listening point.
The default value of the "print-messages" and "name-lookup" are defined by constants (which are set to true by default) in options.h and can be overriden by properties on $server_options
Please note that the listening point created in-server by the main() loop use the default constants, not the $server_options, the reason is that I wanted $server_options to only affect the listen() done in-db.
Enjoy,
Janus
None
This patch is maintainer checked[tm]. At least if he uploads the bugfix we just talked about.
The patch now push the option gather down to new_slistener and network_make_listener, when one of those use an option not provided in the options list passed to listen() they add the used option to the options list. That options list will be in the output of listeners().
So the output of listeners( will depends on both the input value to listen() and the network mode/options. The only guarantee made is that no valid options passed to listen() will be deleted from the options list that is returned by listeners for the listening point.