Re: [L2tpd-devel] Unix98 PTY patch

[<je...@au...>]

On Fri, Jan 18, 2002 at 12:29:24PM -0500, Jeff Mcadams wrote:
> Hrmm...my Debian woody box doesn't seem to have any man pages about
> grantpt() and related, so I haven't been able to check if this is
> reasonable...I'll go ahead and commit it though (it can always be backed
> out).

There is very basic documentation in /usr/share/stdlib.h.  There is more
detailed documentation at:
http://www.gnu.org/manual/glibc-2.2.3/html_chapter/libc_17.html#SEC375


It probably isn't necessary since l2tpd is running as root.  If l2tpd
could be hacked to run as non-root for most of it's functions then it
would be a good idea to leave it.

If getpt() would return a Unix98 PTY then it might be better to use that
except it's a GNU extension.  On the other hand openpty() as declared by
pty.h would be more portable if it does the same thing.

> Also...for small patches like this, its probably not really very helpful
> to gzip them...makes it rather more difficult to review them before
> applying them.  :)

Whoops I don't know why I did that!

> Cool...that will be nice for figuring out what pty or tty code we will
> need at the very least.

And detecting the operating system.

-- 
Jeremy Lunn
Melbourne, Australia
http://www.jabber.org/ - the next generation of Instant Messaging.