Re: [L2tpd-devel] Unix98 PTY patch

[Jeff M. <je...@ig...>]

Also sprach Jeremy Lunn
>Here is a very simple patch to use Unix98 PTYs instead of the old BSD
>style ones.  As a sidenote if /dev/ptmx is not available but
>/usr/include/pty.h is then it should probably be used instead of the
>current code but I don't know enough about this yet.

Hrmm...my Debian woody box doesn't seem to have any man pages about
grantpt() and related, so I haven't been able to check if this is
reasonable...I'll go ahead and commit it though (it can always be backed
out).

Also...for small patches like this, its probably not really very helpful
to gzip them...makes it rather more difficult to review them before
applying them.  :)

>Also would be nice to move all source files into a src directory.

Aha...good thought.  In conjunction with running *.c and *.h through
indent to programatically clean up the code...this will work well.

The only reason I hadn't run indent on this stuff already was because it
would make diffs be this huge mess of crap once it was committed.
Starting with a new directory, though, should prevent that from being a
significant problem.  It will still be hard to compare code before this
point and after it, but at least it won't look so ugly.  :)

>And I might have a play around with autoconf later today (eeer it's 3am
>and I need some sleep!).

Cool...that will be nice for figuring out what pty or tty code we will
need at the very least.
-- 
Jeff McAdams                            Email: je...@ig...
Head Network Administrator              Voice: (502) 966-3848
IgLou Internet Services                        (800) 436-4456