Re: [kvm-devel] [PATCH 02 of 11] get_task_mm

[Andrea A. <an...@qu...>]

On Wed, May 07, 2008 at 10:59:48AM -0500, Robin Holt wrote:
> You can drop this patch.
> 
> This turned out to be a race in xpmem.  It "appeared" as if it were a
> race in get_task_mm, but it really is not.  The current->mm field is
> cleared under the task_lock and the task_lock is grabbed by get_task_mm.

100% agreed, I'll nuke it as it seems really a noop.

> I have been testing you v15 version without this patch and not
> encountere the problem again (now that I fixed my xpmem race).

Great. About your other deadlock I'm curious if my deadlock fix for
the i_mmap_sem patch helped. That was crashing kvm with a VM 2G in the
swap + a swaphog allocating and freeing another 2G of swap in a
loop. I couldn't reproduce any other problem with KVM since I fixed
that bit regardless if I apply only mmu-notifier-core (2.6.26 version)
or the full patchset (post 2.6.26).