Re: [kvm-devel] [PATCH] [ACPI] Enable direct GSI mapping for APIC

[Avi K. <av...@qu...>]

Alexander Graf wrote:
> Hi,
>
> in the DSDT there are two different ways of defining, how an interrupt 
> is supposed to be routed. Currently we are using the LNKA - LNKD 
> method, which afaict is for legacy support.
> The other method is to directly tell the Operating System, which APIC 
> pin the device is attached to. We can get that information from the 
> very same entry, the LNKA to LNKD pseudo devices receive it.
>
> For now this does not give any obvious improvement. It does leave room 
> for more advanced mappings, with several IOAPICs that can handle more 
> devices separately. This might help when we have a lot of devices, as 
> currently all devices sit on two interrupt lanes.
>
> More importantly (for me) though, is that Darwin enables the APIC mode 
> unconditionally, so it won't easily run in legacy mode.
>

Please properly signoff on patches.

Also:

> +                // PCI Slot 8
> +                Package() {0x0008ffff, 0, 0, ARQ3},
> +                Package() {0x0008ffff, 1, 0, ARQ0},
> +                Package() {0x0008ffff, 2, 0, ARQ1},
> +                Package() {0x0008ffff, 3, 0, ARQ2},
> +
> +                // PCI Slot 9
> +                Package() {0x0008ffff, 0, 0, ARQ0},
> +                Package() {0x0008ffff, 1, 0, ARQ1},
> +                Package() {0x0008ffff, 2, 0, ARQ2},
> +                Package() {0x0008ffff, 3, 0, ARQ3},
> +

Slot 9 uses the same addresses as slot 8.   Similarly for slot 25. 
(found by Marcelo for the code which was the source for this copy-paste)

-- 
error compiling committee.c: too many arguments to function