Re: [kvm-ia64-devel] [kvm-devel] [PATCH] Build fix for kvm/ia64 userspace.

[Zhang, X. <xia...@in...>]

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Hi, Avi
>>   This patch should go into RC1, otherwise it will block kvm/ia64
>> userspace build. 
>> 
>> diff --git a/include/asm-ia64/kvm.h b/include/asm-ia64/kvm.h index
>> eb2d355..62b5fad 100644 --- a/include/asm-ia64/kvm.h
>> +++ b/include/asm-ia64/kvm.h
>> @@ -22,7 +22,12 @@
>>   */
>> 
>>  #include <asm/types.h>
>> +
>> +#ifdef __KERNEL__
>>  #include <asm/fpu.h>
>> +#else
>> +#include <signal.h>
>> +#endif
>> 
> 
> Fishy.  A kernel header including a userspace header?
> 
> Maybe you need to include <linux/signal.h> unconditionally?
Hi, Avi 
	You know, kvm.h is shared by userspace and kernel. But
unfortunately, the usersapce header files have redefinition for one
strucutre (structure ia64_fpreg) {One in asm/fpu.h and the other one in
bits/sigcontext}, maybe a bug here. 
	 Therefore, if userspace code includes fpu.h and sigcontext.h in
one source file, it will complain the redefinition.  Do you have good
idea to cope with this issue ?
Xiantao