Re: [kvm-devel] [PATCH 1/4] Replace SIGUSR1 in io-thread with eventfd() (v2)

[Anthony L. <ali...@us...>]

Marcelo Tosatti wrote:
> Looks good (the whole series).
>
> Needs some good testing of course... Have you tested migration/loadvm?
>   

No, but I will before resubmitting (which should be sometime tomorrow).

Regards,

Anthony Liguori

> On Mon, May 05, 2008 at 08:47:12AM -0500, Anthony Liguori wrote:
>   
>> It's a little odd to use signals to raise a notification on a file descriptor
>> when we can just work directly with a file descriptor instead.  This patch
>> converts the SIGUSR1 based notification in the io-thread to instead use an
>> eventfd file descriptor.  If eventfd isn't available, we use a pipe() instead.
>>
>> The benefit of using eventfd is that multiple notifications will be batched
>> into a signal IO event.
>>
>> Signed-off-by: Anthony Liguori <ali...@us...>
>>