Re: [kvm-ia64-devel] [kvm-devel] [PATCH] Build fix for kvm/ia64 userspace.

[Avi K. <av...@qu...>]

Zhang, Xiantao wrote:
> Hi, Avi
>   This patch should go into RC1, otherwise it will block kvm/ia64
> userspace build. 
>
> diff --git a/include/asm-ia64/kvm.h b/include/asm-ia64/kvm.h
> index eb2d355..62b5fad 100644
> --- a/include/asm-ia64/kvm.h
> +++ b/include/asm-ia64/kvm.h
> @@ -22,7 +22,12 @@
>   */
>  
>  #include <asm/types.h>
> +
> +#ifdef __KERNEL__
>  #include <asm/fpu.h>
> +#else
> +#include <signal.h>
> +#endif
>  

Fishy.  A kernel header including a userspace header?

Maybe you need to include <linux/signal.h> unconditionally?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.