Re: [kvm-devel] KVM-66: FreeBSD guest takes all CPU when idle

[Aurelien J. <aur...@au...>]

On Fri, May 02, 2008 at 07:23:22PM -0300, Marcelo Tosatti wrote:
> On Fri, May 02, 2008 at 10:39:25PM +0200, Aurelien Jarno wrote:
> > Hi,
> > 
> > Since commit a0d22c57fbf0c67d73ab7ca3416841030e0bc22f, FreeBSD guests
> > takes all host CPU even when they are idle. Reverting this patch in
> > kvm-67 or git tree fixes (or workarounds?) the problem. Using 
> > -no-kvm-pit also workarounds the problem.
> > 
> > Some more details:
> > Host: Linux 2.6.24 x86-64
> > CPU: problem occurs on T7500 and Q9450
> > Guest: problem occurs with FreeBSD/i386 6.2 and 6.3
> > 
> > Regards,
> > Aurelien
> 
> Aurelien,
> 
> Can you give this a try.

Yep, that fixes the problem. Thanks a lot!

> diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
> index 1646102..07f9ff1 100644
> --- a/arch/x86/kvm/i8254.c
> +++ b/arch/x86/kvm/i8254.c
> @@ -216,7 +216,7 @@ int pit_has_pending_timer(struct kvm_vcpu *vcpu)
>  {
>  	struct kvm_pit *pit = vcpu->kvm->arch.vpit;
>  
> -	if (pit && vcpu->vcpu_id == 0)
> +	if (pit && vcpu->vcpu_id == 0 && pit->pit_state.inject_pending)
>  		return atomic_read(&pit->pit_state.pit_timer.pending);
>  
>  	return 0;
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   au...@de...         | aur...@au...
   `-    people.debian.org/~aurel32 | www.aurel32.net