Re: [kvm-devel] [PATCH 4/8] KVM: MMU: Add EPT support

[Avi K. <av...@qu...>]

Yang, Sheng wrote:
> From 239f38236196c2321989c64d7c61ff28490b3f00 Mon Sep 17 00:00:00 2001
> From: Sheng Yang <she...@in...>
> Date: Fri, 25 Apr 2008 21:13:50 +0800
> Subject: [PATCH 4/8] KVM: MMU: Add EPT support
>
> Enable kvm_set_spte() to generate EPT entries.
>
>
> @@ -1155,7 +1178,7 @@ static int __direct_map(struct kvm_vcpu *vcpu, gpa_t v, 
> int write,
>  			}
>
>  			table[index] = __pa(new_table->spt) | PT_PRESENT_MASK
> -				| PT_WRITABLE_MASK | PT_USER_MASK;
> +				| PT_WRITABLE_MASK | shadow_user_mask;
>  		}
>   

Shouldn't we have shadow_x_mask here as well?

[and for non-EPT, shadow_accessed_mask and shadow_dirty_mask, but that's 
a different story].


-- 
error compiling committee.c: too many arguments to function