Re: [kvm-devel] 32-bit binaries failing in 64 bit guests after using vmport

[Soren H. <so...@ub...>]

On Mon, Apr 21, 2008 at 08:51:17AM -0500, Anthony Liguori wrote:
>> We're releasing on Thursday, and I needed a quick fix, so I reverted
>> the calls to kvm_{save,load}_registers in vmport_ioport_read to the
>> old code that simply saved the eax, ebx, ecx, edx, esi, and edi
>> registers, but I'm supposing kvm_{load,save}_registers really should
>> work here.

/me sighs very deeply

Ok, first chance I get, I'm signing up for "Patch management 101". :( I
got some tests mixed around, so it failing is actually dependent on
whether EIP (not LSTAR as I originally thought) is restored or not.

I have a patch that fixes it, but I need to work a few things out first
before I submit it.

> Ah, you may have missed the fix that updated the KVM load/save
> functions  to deal with the in-kernel APIC.

Indeed.

> It turns out, vmmouse was horribly broken with SMP guests too.  See
>
> commit 9949bd84ac4dfdfc60b2974557819637b8719911
> Author: Anthony Liguori <ali...@us...>
> Date:   Thu Apr 3 18:37:16 2008 -0500
>
> commit 5208ce19dca268f84a2b9441c2fbb6129161e44c
> Author: Marcelo Tosatti <mto...@re...>
> Date:   Thu Apr 3 20:24:37 2008 -0300

I did my tests using kvm-65 userland and kernel, so these two should
already be included, afaics.  

> commit 85a67aa2a1b942ddccfcbd625d280869367edc95
> Author: Marcelo Tosatti <mto...@re...>
> Date:   Fri Apr 11 13:24:41 2008 -0300

This did not change anything for me.

-- 
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/