Re: [kvm-devel] pv clock: kvm is incompatible with xen :-(

[Jeremy F. <je...@go...>]

Gerd Hoffmann wrote:
> I'm looking at the guest side of the issue right now, trying to identify
> common code, and while doing so noticed that xen does the
> version-check-loop in both get_time_values_from_xen(void) and
> xen_clocksource_read(void), and I can't see any obvious reason for that.
>  The loop in xen_clocksource_read(void) is not needed IMHO.  Can I drop it?
>   

No.  The get_nsec_offset() needs to be atomic with respect to the 
get_time_values() parameters.  There could be a loopless 
__get_time_values() for use in this case, but given that it almost never 
loops, I don't think its worthwhile.

    J