[kvm-devel] [ kvm-Bugs-1945129 ] Compilation fails when configure with -DDEBUG

[SourceForge.net <no...@so...>]

Bugs item #1945129, was opened at 2008-04-17 14:36
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1945129&group_id=180599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Duilio J. Protti (dprotti)
Assigned to: Nobody/Anonymous (nobody)
Summary: Compilation fails when configure with -DDEBUG

Initial Comment:
When configured kvm-65 with

./configure --prefix=/usr/devel --qemu-cflags=-DDEBUG

Compilation fails with the following error:

gcc34 -I /root/linux/kvm-65/qemu/../libkvm -DDEBUG -DCONFIG_X86 -Wall -O2 -g -fno-strict-aliasing  -m32 -I. -I/root/linux/kvm-65/qemu -MMD -MP -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/root/linux/kvm-65/qemu/slirp -c -o smbus_eeprom.o /root/linux/kvm-65/qemu/hw/smbus_eeprom.c
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_quick_cmd':
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c:40: error: structure has no member named `addr'
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_send_byte':
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c:48: error: structure has no member named `addr'
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_receive_byte':
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c:58: error: structure has no member named `addr'
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c: In function `eeprom_write_data':
/root/linux/kvm-65/qemu/hw/smbus_eeprom.c:68: error: structure has no member named `addr'
make[1]: *** [smbus_eeprom.o] Error 1
make[1]: Leaving directory `/root/linux/kvm-65/qemu'
make: *** [qemu] Error 2

The error comes because structure SMBusDevice does not have a field named 'addr' (probably name has changed since the debugging code was written).

Code conditionally compiled with a DEBUG macro appears in many places in the Qemu code, but it is not driven by a central --debug option or similar, so it seems that the configuration in question (with -DDEBUG) is a little odd and a not supported one.

However, may be the code should be changed or else removed to avoid these useless lines there.

Attached is a simple patch which resolves the issue.

Regards,
Duilio Protti.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1945129&group_id=180599