Re: [kvm-devel] Extboot Option Rom rewritten in C

[Nguyen A. Q. <aq...@gm...>]

On 4/15/08, Anthony Liguori <ali...@us...> wrote:
> Hi Nguyen,
>
>  Nguyen Anh Quynh wrote:
>
> > Hi Anthony,
> >
> > I spot a bug and few dead code in the extboot option rom. Perhaps the
> > reason they are there is because less people want to look at assembly
> > code, and it looks indeed scary.
> >
> > So I decided to rewrite it in C, using .code16gcc directive. Some
> advantages:
> > - C code is easier to understand, find bugs, maintain and hack (so we
> > can add more features in the future)
> > - The binary image is same: 1.5K. The actual code size is also about
> > the same size: around 1.2K. (gcc can optimize really well)
> >
> >
>
>  I think converting to code16gcc is a good direction to go in.  I actually
> rewrote it myself using code16gcc but I ran into problems with segment
> assumptions and Windows guests.  I tried out your version with a Linux guest
> with good success but it fails with a win2k guest.
>
>  Have you tested with a Windows guest?

Not yet. Last time I tried, the Windows virtio drivers posted a while
ago dont work with my WinXP. I will try again, though.

>  If we can work through the Windows
> issues, this is definitely the right way to go.

So the assembly option rom works with your Win2k?? If so, definitely
we can fix the C code.

Thanks,
Quynh