Re: [kvm-ppc-devel] [PATCH] [3/3] kvmppc: make tlb tracing configurable

[Arnd B. <ar...@ar...>]

On Monday 14 April 2008, ehr...@li... wrote:
> @@ -58,6 +58,14 @@ config KVM_POWERPC_440_TRACE_INSTRUCTION
>           channel.
>           If unsure, say N.
>  
> +config KVM_POWERPC_440_TRACE_TLB
> +       bool "ppc440 guest tlb activity tracing"
> +       depends on KVM && 44x && KVM_POWERPC_440
> +       select RELAY
> +       ---help---
> +         Adds the complete tracing of the tlb activities via a relayfs channel.
> +         If unsure, say N.
> +

I think you're taking the configurability a little too far, do you really
want users to be able to select the three new tracing options separately?
Choosing between all stats and no stats at all sounds sufficient to me.

	Arnd <><