Re: [kvm-devel] [PATCH] add ioctl's to save/restore mpstate

[Avi K. <av...@qu...>]

Marcelo Tosatti wrote:
>  /*
>   * ioctls for VM fds
> @@ -340,5 +341,7 @@ struct kvm_s390_interrupt {
>  #define KVM_S390_SET_INITIAL_PSW  _IOW(KVMIO,  0x96, struct kvm_s390_psw)
>  /* initial reset for s390 */
>  #define KVM_S390_INITIAL_RESET    _IO(KVMIO,  0x97)
> +#define KVM_GET_MP_STATE	  _IO(KVMIO,  0x98)
> +#define KVM_SET_MP_STATE	  _IO(KVMIO,  0x99)
>   

This needs _IOW or _IORW to document transfer direction and structure 
size.  Please put the data in a structure, and document the values by 
moving the #defines into linux/kvm.h

-- 
Any sufficiently difficult bug is indistinguishable from a feature.