From: Avi K. <av...@qu...> - 2008-04-11 00:06:08
|
Marcelo Tosatti wrote: > On Wed, Apr 09, 2008 at 12:59:50AM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> Avi, I prefer not to fold mpstate into kvm_save_registers() as a hidden >>> register because the MPSTATE is only used during migration, whereas >>> save_registers() is not (seems safer) >>> >> But that's the point... what about savevm/loadvm, etc? They deserve to >> work too. >> > > savevm/loadvm will work through cpu_save/cpu_load just as live migration > does, so they are covered. > > Right. -- Any sufficiently difficult bug is indistinguishable from a feature. |