Re: [kvm-ia64-devel] [16/18]KVM:IA64 : Add kvm sal/palvirtulization support.V9

[Zhang, X. <xia...@in...>]

Changed to be a soft and clear saying. Thanks! :-)
Xiantao

Jes Sorensen wrote:
> Zhang, Xiantao wrote:
>>> From 5c70c038c57190144390ae9d30c3d06afba103d4 Mon Sep 17 00:00:00
>>> 2001 
>> From: Xiantao Zhang <xia...@in...>
>> Date: Tue, 1 Apr 2008 14:59:30 +0800
>> Subject: [PATCH] KVM:IA64 : Add kvm sal/pal virtulization support.
>> 
>> Some sal/pal calls would be traped to kvm for virtulization
>> from guest firmware.
>> Signed-off-by: Xiantao Zhang <xia...@in...> ---
>>  arch/ia64/kvm/kvm_fw.c |  500
> 
> Hi Xiantao,
> 
> A few more comments:
> 
> 
>> --- /dev/null
>> +++ b/arch/ia64/kvm/kvm_fw.c
> 
>> +static void kvm_get_pal_call_data(struct kvm_vcpu *vcpu,
>> +		u64 *gr28, u64 *gr29, u64 *gr30, u64 *gr31) {
>> +	struct exit_ctl_data *p;
>> +
>> +	if (vcpu) {
>> +		p = &vcpu->arch.exit_data;
>> +		if (p->exit_reason == EXIT_REASON_PAL_CALL) {
>> +			*gr28 = p->u.pal_data.gr28;
>> +			*gr29 = p->u.pal_data.gr29;
>> +			*gr30 = p->u.pal_data.gr30;
>> +			*gr31 = p->u.pal_data.gr31;
>> +			return ;
>> +		}
>> +	}
>> +	printk(KERN_DEBUG"Error occurs in kvm_get_pal_call_data!!\n");
> 
> Maybe make this error message a bit more elaborate with information
> about what the error is?
> 
>> +static void set_sal_result(struct kvm_vcpu *vcpu,
>> +		struct sal_ret_values result) {
>> +	struct exit_ctl_data *p;
>> +
>> +	p = kvm_get_exit_data(vcpu);
>> +	if (p && p->exit_reason == EXIT_REASON_SAL_CALL) {
>> +		p->u.sal_data.ret = result;
>> +		return ;
>> +	}
>> +	printk(KERN_WARNING"Error occurs!!!\n");
> 
> I love this error message :-) Seriously though, please make it say
> where it is and what has been detected.
> 
> Cheers,
> Jes
> 
>
------------------------------------------------------------------------
-
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
>
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketp
lace
> _______________________________________________
> kvm-ia64-devel mailing list
> kvm...@li...
> https://lists.sourceforge.net/lists/listinfo/kvm-ia64-devel