Re: [kvm-ia64-devel] [kvm-devel] [07/17][PATCH] kvm/ia64: Add TLB virtulizationsupport.-V8

[Zhang, X. <xia...@in...>]

Jes Sorensen wrote:
> Zhang, Xiantao wrote:
>>> From 6b731c15afa8cec84f16408c421c286f1dd1b7d3 Mon Sep 17 00:00:00
>>> 2001 
>> From: Xiantao Zhang <xia...@in...>
>> Date: Wed, 12 Mar 2008 13:45:40 +0800
>> Subject: [PATCH] KVM:IA64 : Add TLB virtulization support.
>> 
>> vtlb.c includes tlb/VHPT virtulization.
>> Signed-off-by: Anthony Xu <ant...@in...>
>> Signed-off-by: Xiantao Zhang <xia...@in...>
> 
> Hi Xiantao,
> 
> Just a clarification question on this one:
> 
> 
>> +void machine_tlb_purge(u64 va, u64 ps)
>> +{
>> +	ia64_ptcl(va, ps << 2);
>> +}
> 
> What is the purpose of machine_tlb_purge()? Is it supposed to do a
> global purge of the tlb on the host machine? If so, how does this
> macro differ from platform_global_tlb_purge()?
Hi, Jes
	Not for global purge, and just for purge local processsor's TLB
entry covered by the parameters :-)
Xiantao

> I am mentioning this because it's very important to keep in mind that
> the regular tlb purging instructions are not functional on all ia64
> platforms, which is why we have special implementations via the
> machine vector interface.

If global puge,  we indeed need to consider the machine vectore.