Re: [kvm-ia64-devel] [kvm-devel] [PATCH] Converting mmio to port io in userspace for IA64

[Avi K. <av...@qu...>]

Zhang, Xiantao wrote:
> From: Zhang Xiantao <xia...@in...>
> Date: Thu, 31 Jan 2008 09:06:21 +0800
> Subject: [PATCH] kvm: qemu: Covert the mmio address space to port io in
> userspace.
>
> IA64 also have no port io, but chipset is responsible for converting
> some mmio to port io for keeping compatibility with legacy deviceS.
> @@ -56,6 +56,60 @@ static fdctrl_t *floppy_controller;
>  static RTCState *rtc_state;
>  static PCIDevice *i440fx_state;
>  
> +#define TO_LEGACY_IO(addr)  (((addr&0x3ffffff) >> 12 << 2)|((addr) &
> 0x3))
>   

Please change to a function.  Other than that, patch looks good.


-- 
error compiling committee.c: too many arguments to function