Re: [kvm-ia64-devel] [kvm-devel] [PATCH] Clean up KVM/QEMU interaction

[Avi K. <av...@qu...>]

Avi Kivity wrote:
> Anthony Liguori wrote:
>   
>> This patch attempts to clean up the interactions between KVM and QEMU.  Sorry
>> for such a big patch, but I don't think there's a better way to approach this
>> such that it's still bisect friendly.  I think this is most of what's needed to
>> get basic KVM support into QEMU though.
>>
>> Right now, there's a mix of #ifdef USE_KVM, if (kvm_allowed), and various
>> extern declarations.  It's all pretty fugly and there's a lot of mistakes due
>> to it.
>>
>> The following patch eliminates almost all uses of #ifdef USE_KVM by introducing
>> a kvm_enabled() macro.  If USE_KVM is set, this macro evaluates to kvm_allowed.
>> If USE_KVM isn't set, the macro evaluates to 0.
>>
>> Since GCC eliminates if (0) blocks, this is just as good as using #ifdef.  By
>> making sure that we never call into libkvm directly from QEMU, we can also just
>> not link qemu-kvm when USE_KVM isn't set instead of having the entire file
>> wrapped in a USE_KVM.
>>
>>   
>>     
[snip objections]

I guess I ought to merge this regardless. This type of patch ages 
quickly, so it's better to apply it now and fix any issues later.

I'll wait a few more hours to see if anyone has issues and then apply.

-- 
error compiling committee.c: too many arguments to function