Re: [kvm-devel] [resend] [PATCH] MSR_IA32_PERF_STATUS support

[Avi K. <av...@qu...>]

Alexander Graf wrote:
> Avi Kivity wrote:
>   
>> Alexander Graf wrote:
>>   
>>     
>>> This is a resend of a mail I sent on 01/10/2008. I did not receive any
>>> response, so I assume it was lost.
>>>
>>> The patch is really minor, does not break any compatibility (the MSR is
>>> Intel family 13+) and makes Darwin work.
>>>
>>> --- old mail ---
>>>
>>> This patch adds support for the MSR MSR_IA32_PERF_STATUS. This is
>>> required to boot Darwin.
>>>
>>> I only implemented dummy support, as the real value would be of no
>>> meaning to any OS I know so far anyway and is only implemented on very
>>> recent Intel CPUs.
>>>
>>>   
>>>     
>>>       
>> Looks okay, but please add a signoff line and use the kernel coding 
>> style (tabs and comment style).
>>
>>
>>
>>   
>>     
> Ok, should I resend the patch with a signed-off line and proper coding
> style?
>   

Yes please.  I'm a little worried that this can confuse other guests, 
but as it's read only and a large variety have run so far without 
complaining, it's probably safe enough.

-- 
error compiling committee.c: too many arguments to function