Re: [kvm-devel] [PATCH] Enhnace kvm-userspace configure script for powerpc

[Anthony L. <ali...@us...>]

Jerone Young wrote:
> My upstream must be out of date. But the way upstream seems really
> awful. If I mistype any valid option then I don't even get an error.
> It's passed as a qemu option. This does not seem to be a great idea,
> causes more headaches.
>   

Sure, and QEMU will complain about it.

Regards,

Anthony Liguori

>
> On Tue, 2008-01-08 at 16:03 -0600, Anthony Liguori wrote:
>   
>> Jerone Young wrote:
>>     
>>> # HG changeset patch
>>> # User Jerone Young <jy...@us...>
>>> # Date 1199829366 21600
>>> # Node ID 5d3976c5b77e42ad1f63d02271a7ff2086cabb6c
>>> # Parent  bff590d13f32071b50d79f511424821847ed5ba7
>>> Enhnace kvm-userspace configure script for powerpc
>>>
>>>
>>> This patch adds more options to compile qemu with and
>>> places a conditional for powerpc to compile qemu.
>>>
>>> Signed-off-by: Jerone Young <jy...@us...>
>>>
>>> diff --git a/configure b/configure
>>> --- a/configure
>>> +++ b/configure
>>> @@ -8,7 +8,10 @@ qemu_ldflags=
>>>  qemu_ldflags=
>>>  enable_alsa=
>>>  disable_vnc_tls=
>>> +disable_sdl=
>>> +disable_gfx_check=
>>>  disable_gcc_check=
>>> +enable_qemu_static=
>>>  cross_prefix=
>>>  arch=`uname -m`
>>>  target_exec=
>>> @@ -28,8 +31,11 @@ usage() {
>>>  	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
>>>  	    --enable-alsa          enable alsa support for qemu
>>>  	    --disable-vnc-tls      disable vnc tls support for qemu
>>> +	    --disable-sdl          disable sdl support for qemu
>>> +	    --disable-gfx-check    disable graphics check for qemu
>>>  	    --disable-gcc-check    don't insist on gcc-3.x
>>>  	                           CAUTION: this will break running without kvm
>>> +	    --qemu-static          compile qemu to be a static executable
>>>  EOF
>>>      exit 1
>>>  }
>>> @@ -66,8 +72,17 @@ while [[ "$1" = -* ]]; do
>>>  	--disable-vnc-tls)
>>>  	    disable_vnc_tls=1
>>>  	    ;;
>>> +	--disable-sdl)
>>> +	    disable_sdl=1
>>> +	    ;;
>>> +	--disable-gfx-check)
>>> +	    disable_gfx_check=1
>>> +	    ;;
>>>  	--disable-gcc-check)
>>>  	    disable_gcc_check=1
>>> +	    ;;
>>>   
>>>       
>> I believe that unknown options are passed directly to QEMU so I don't 
>> think this is strictly necessary.  It should Just Work already.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>     
>>> +	--qemu-static)
>>> +	    enable_qemu_static=1
>>>  	    ;;
>>>  	--arch)
>>>  	    arch="$arg"
>>> @@ -106,6 +121,10 @@ if [ "$arch" = "ia64" ]; then
>>>      target_exec="ia64-softmmu"
>>>  fi
>>>  
>>> +if [ "$arch" = "powerpc" ]; then
>>> +    target_exec="ppcemb-softmmu"
>>> +fi
>>> +
>>>  #configure user dir
>>>  (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
>>>            --arch="$arch" \
>>> @@ -120,8 +139,11 @@ fi
>>>      ${enable_alsa:+"--enable-alsa"} \
>>>      ${disable_vnc_tls:+"--disable-vnc-tls"} \
>>>      ${disable_gcc_check:+"--disable-gcc-check"} \
>>> +    ${disable_sdl:+"--disable-sdl"} \
>>> +    ${disable_gfx_check:+"--disable-gfx-check"} \
>>>      --prefix="$prefix" \
>>>      ${qemu_cc:+"--cc=$qemu_cc"} \
>>> +    ${enable_qemu_static:+"--static"} \
>>>      ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
>>>      ${cross_prefix:+"--cpu=$arch"}
>>>  )
>>>
>>> -------------------------------------------------------------------------
>>> Check out the new SourceForge.net Marketplace.
>>> It's the best place to buy or sell services for
>>> just about anything Open Source.
>>> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
>>> _______________________________________________
>>> kvm-devel mailing list
>>> kvm...@li...
>>> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>>>   
>>>       
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> kvm-devel mailing list
> kvm...@li...
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>