Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

[Avi K. <av...@qu...>]

Laurent Vivier wrote:
> What I'm wondering now is: is it really useful to have "cache=off" and
> "snapshot=on" at the same time ?
>   

No idea, but wouldn't want to rule it out.

> If not, the patch of Carlo is good, otherwise there is more
> modifications to do (in other parts of qemu).
>   

If other modifications are needed, perhaps do them in the I/O submission 
path (if unaligned and cache=off, force alignment).  Since most of the 
data will be aligned by the guest, the overhead will only be incurred by 
the rare metadata accesses.


-- 
error compiling committee.c: too many arguments to function