Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

[Laurent V. <Lau...@bu...>]

Le lundi 07 janvier 2008 =C3=A0 12:47 +0200, Avi Kivity a =C3=A9crit :
> Laurent Vivier wrote:
> > Le lundi 07 janvier 2008 =C3=A0 11:27 +0200, Avi Kivity a =C3=A9crit :
> >  =20
> >> Carlo Marcelo Arenas Belon wrote:
> >>    =20
> >>> revert a merge conflict from 075da586c92f09bd9a7401f1e80d72fde27c173 =
that
> >>> redefined sector as an array of pointers to char, instead of a static=
ally
> >>> allocated buffer of chars, that was triggering the following warnings=
 :
> >>>
> >>> block.c: In function `bdrv_commit':
> >>> block.c:480: warning: passing arg 3 of `bdrv_read' from incompatible =
pointer type
> >>> block.c:484: warning: passing arg 3 of `bdrv_write' from incompatible=
 pointer type
> >>>
> >>> Signed-off-by: Carlo Marcelo Arenas Belon <ca...@sa...>
> >>>  =20
> >>>      =20
> >> Doesn't the cache=3Doff option warrant an allocation here to ensure=20
> >> alignment (or perhaps a 1K stack buffer with runtime adjustment)?
> >>    =20
> >
> > You're right, a good patch should be something like this (it is not
> > tested or even compiled) :
> >  =20
>=20
> Looks good, but patch is corrupted by mail client.

What I'm wondering now is: is it really useful to have "cache=3Doff" and
"snapshot=3Don" at the same time ?
If not, the patch of Carlo is good, otherwise there is more
modifications to do (in other parts of qemu).

Regards,
Laurent
--=20
----------------- Lau...@bu...  ------------------
  "La perfection est atteinte non quand il ne reste rien =C3=A0
ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry