Re: [kvm-devel] [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit

[Avi K. <av...@qu...>]

Carlo Marcelo Arenas Belon wrote:
> revert a merge conflict from 075da586c92f09bd9a7401f1e80d72fde27c173 that
> redefined sector as an array of pointers to char, instead of a statically
> allocated buffer of chars, that was triggering the following warnings :
>
> block.c: In function `bdrv_commit':
> block.c:480: warning: passing arg 3 of `bdrv_read' from incompatible pointer type
> block.c:484: warning: passing arg 3 of `bdrv_write' from incompatible pointer type
>
> Signed-off-by: Carlo Marcelo Arenas Belon <ca...@sa...>
>   

Doesn't the cache=off option warrant an allocation here to ensure 
alignment (or perhaps a 1K stack buffer with runtime adjustment)?

-- 
error compiling committee.c: too many arguments to function