kvm-devel

[kvm-devel] kvm-userspace fails to compile

[Laurent V. <Lau...@bu...>]

The error is:

libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report':
/home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221:
undefined reference to `kvm_enable_vapic'
libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_opt_setup':
/home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:287:
undefined reference to `kvm_enable_tpr_access_reporting'
collect2: ld returned 1 exit status
make[2]: *** [qemu-system-x86_64] Error 1
make[2]: Leaving directory
`/home/vivierl/Projects/KVM/kvm-userspace/qemu/x86_64-softmmu'
make[1]: *** [subdir-x86_64-softmmu] Error 2
make[1]: Leaving directory
`/home/vivierl/Projects/KVM/kvm-userspace/qemu'
make: *** [qemu] Error 2

Any idea ?

Laurent
--=20
----------------- Lau...@bu...  ------------------
  "La perfection est atteinte non quand il ne reste rien =C3=A0
ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry

[kvm-devel] kvm-userspace fails to compile

[Laurent V. <Lau...@bu...>]

The error is:

libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report':
/home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221:
undefined reference to `kvm_enable_vapic'
libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_opt_setup':
/home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:287:
undefined reference to `kvm_enable_tpr_access_reporting'
collect2: ld returned 1 exit status
make[2]: *** [qemu-system-x86_64] Error 1
make[2]: Leaving directory
`/home/vivierl/Projects/KVM/kvm-userspace/qemu/x86_64-softmmu'
make[1]: *** [subdir-x86_64-softmmu] Error 2
make[1]: Leaving directory
`/home/vivierl/Projects/KVM/kvm-userspace/qemu'
make: *** [qemu] Error 2

Any idea ?

Laurent
--=20
----------------- Lau...@bu...  ------------------
  "La perfection est atteinte non quand il ne reste rien =C3=A0
ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry

Re: [kvm-devel] kvm-userspace fails to compile

[Dor L. <dor...@gm...>]

On Mon, 2008-01-07 at 14:14 +0100, Laurent Vivier wrote:
> The error is:
> 
> libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report':
> /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221:
> undefined reference to `kvm_enable_vapic'
> libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_opt_setup':
> /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:287:
> undefined reference to `kvm_enable_tpr_access_reporting'
> collect2: ld returned 1 exit status
> make[2]: *** [qemu-system-x86_64] Error 1
> make[2]: Leaving directory
> `/home/vivierl/Projects/KVM/kvm-userspace/qemu/x86_64-softmmu'
> make[1]: *** [subdir-x86_64-softmmu] Error 2
> make[1]: Leaving directory
> `/home/vivierl/Projects/KVM/kvm-userspace/qemu'
> make: *** [qemu] Error 2
> 
> Any idea ?
> 

Please do another pull, it was temporary broken yesterday.
Dor

> Laurent
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ kvm-devel mailing list kvm...@li... https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [kvm-devel] kvm-userspace fails to compile

[Laurent V. <Lau...@bu...>]

Le lundi 07 janvier 2008 =C3=A0 15:26 +0200, Dor Laor a =C3=A9crit :
> On Mon, 2008-01-07 at 14:14 +0100, Laurent Vivier wrote:
> > The error is:
> >=20
> > libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_access_report':
> > /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:221:
> > undefined reference to `kvm_enable_vapic'
> > libqemu.a(kvm-tpr-opt.o): In function `kvm_tpr_opt_setup':
> > /home/vivierl/Projects/KVM/kvm-userspace/qemu/kvm-tpr-opt.c:287:
> > undefined reference to `kvm_enable_tpr_access_reporting'
> > collect2: ld returned 1 exit status
> > make[2]: *** [qemu-system-x86_64] Error 1
> > make[2]: Leaving directory
> > `/home/vivierl/Projects/KVM/kvm-userspace/qemu/x86_64-softmmu'
> > make[1]: *** [subdir-x86_64-softmmu] Error 2
> > make[1]: Leaving directory
> > `/home/vivierl/Projects/KVM/kvm-userspace/qemu'
> > make: *** [qemu] Error 2
> >=20
> > Any idea ?
> >=20
>=20
> Please do another pull, it was temporary broken yesterday.
> Dor

Thank you for the answer Dor,

but a pull doesn't resolve anything (the clone has the same effect).

Is the correction has been pushed... ?

Laurent
--=20
----------------- Lau...@bu...  ------------------
  "La perfection est atteinte non quand il ne reste rien =C3=A0
ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry

Re: [kvm-devel] kvm-userspace fails to compile

[Avi K. <av...@qu...>]

Laurent Vivier wrote:
> but a pull doesn't resolve anything (the clone has the same effect).
>
> Is the correction has been pushed... ?
>
>   

Should be...

Perhaps a ./configure is needed.

What's your HEAD?  I have a5b3d2c9b4d4ca3e02f294d14c7df016e070bda7, 
which compiles fine.


-- 
error compiling committee.c: too many arguments to function

Re: [kvm-devel] kvm-userspace fails to compile

[Laurent V. <Lau...@bu...>]

Le lundi 07 janvier 2008 =C3=A0 15:57 +0200, Avi Kivity a =C3=A9crit :
> Laurent Vivier wrote:
> > but a pull doesn't resolve anything (the clone has the same effect).
> >
> > Is the correction has been pushed... ?
> >
> >  =20
>=20
> Should be...
>=20
> Perhaps a ./configure is needed.
>=20
> What's your HEAD?  I have a5b3d2c9b4d4ca3e02f294d14c7df016e070bda7,=20
> which compiles fine.

OK, I found where is the problem: my KERNELDIR is not the good one.

Thank you for the answers.

Laurent
--=20
----------------- Lau...@bu...  ------------------
  "La perfection est atteinte non quand il ne reste rien =C3=A0
ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry

Re: [kvm-devel] kvm-userspace fails to compile

[Christoph H. <hc...@in...>]

On Mon, Jan 07, 2008 at 03:25:50PM +0100, Laurent Vivier wrote:
> > Perhaps a ./configure is needed.
> > 
> > What's your HEAD?  I have a5b3d2c9b4d4ca3e02f294d14c7df016e070bda7, 
> > which compiles fine.
> 
> OK, I found where is the problem: my KERNELDIR is not the good one.
> 
> Thank you for the answers.

Looks like you were hitting the same problem that I did.  So what's the
correct KERNELDIR?  Care to post your ./configure line?

I have to add that having compile of userspace code depend on a kernel
dir is completely broken.  Any chance the kvm maintainers can fix
userspace code to compile standalone and not depend on a kernel?  Best
would be to have userspace and the standalone kernel module in entirely
different repositories.

Re: [kvm-devel] kvm-userspace fails to compile

[Laurent V. <Lau...@bu...>]

Le mardi 15 janvier 2008 =C3=A0 15:49 +0000, Christoph Hellwig a =C3=A9crit=
 :
> On Mon, Jan 07, 2008 at 03:25:50PM +0100, Laurent Vivier wrote:
> > > Perhaps a ./configure is needed.
> > >=20
> > > What's your HEAD?  I have a5b3d2c9b4d4ca3e02f294d14c7df016e070bda7,=20
> > > which compiles fine.
> >=20
> > OK, I found where is the problem: my KERNELDIR is not the good one.
> >=20
> > Thank you for the answers.
>=20
> Looks like you were hitting the same problem that I did.  So what's the
> correct KERNELDIR?  Care to post your ./configure line?

It was where I put my KVM kernel sources, for instance:

KERNELDIR=3D/home/vivierl/Projects/KVM/kvm

generated by:

./configure --kerneldir=3D/home/vivierl/Projects/KVM/kvm \
--with-patched-kernel

ls /home/vivierl/Projects/KVM/kvm

arch     Documentation  ipc          Makefile        REPORTING-BUGS
System.map
block    drivers        Kbuild       mm              samples         usr
COPYING  fs             kernel       Module.symvers  scripts
virt
CREDITS  include        lib          net             security
vmlinux
crypto   init           MAINTAINERS  README          sound
vmlinux.o

	=09
> I have to add that having compile of userspace code depend on a kernel
> dir is completely broken.  Any chance the kvm maintainers can fix
> userspace code to compile standalone and not depend on a kernel?  Best
> would be to have userspace and the standalone kernel module in entirely
> different repositories.

Regards,
Laurent
--=20
----------------- Lau...@bu...  ------------------
  "La perfection est atteinte non quand il ne reste rien =C3=A0
ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry

Re: [kvm-devel] kvm-userspace fails to compile

[Avi K. <av...@qu...>]

Christoph Hellwig wrote:
> I have to add that having compile of userspace code depend on a kernel
> dir is completely broken.  Any chance the kvm maintainers can fix
> userspace code to compile standalone and not depend on a kernel?  

That's the plan, but since things work for most people that area is not 
seeing much attention.  The problem areas are compiling userspace 
against older kernels, and that's not something we do often.

> Best
> would be to have userspace and the standalone kernel module in entirely
> different repositories.
>   

The standalone kernel module is actually not kept in source control; 
instead it is generated by copying the files from a standard kernel tree 
and gently massaging them with a big hammer.

-- 
error compiling committee.c: too many arguments to function

Re: [kvm-devel] kvm-userspace fails to compile

[Christoph H. <hc...@in...>]

On Tue, Jan 15, 2008 at 05:55:20PM +0200, Avi Kivity wrote:
> That's the plan, but since things work for most people that area is not 
> seeing much attention.  The problem areas are compiling userspace against 
> older kernels, and that's not something we do often.

Well, the point is there should be no compiling against older kernels or
kernels in general.  A userspace tarball should be entirely
self-contained and not care about any kind of kerneldir or similar.

Re: [kvm-devel] kvm-userspace fails to compile

[Avi K. <av...@qu...>]

Christoph Hellwig wrote:
> On Tue, Jan 15, 2008 at 05:55:20PM +0200, Avi Kivity wrote:
>   
>> That's the plan, but since things work for most people that area is not 
>> seeing much attention.  The problem areas are compiling userspace against 
>> older kernels, and that's not something we do often.
>>     
>
> Well, the point is there should be no compiling against older kernels or
> kernels in general.  A userspace tarball should be entirely
> self-contained and not care about any kind of kerneldir or similar.
>
>   

Yes, you're right.  My confusion arose because we have two distinct 
needs for a "kernel directory":

1. A build directory for the external module (which really needs to be a 
kernel directory)
2. A directory with the exported userspace headers (like /usr/include)

We are using one directory for both.  Once we separate this, the mess 
should be cleared up.

-- 
error compiling committee.c: too many arguments to function

Re: [kvm-devel] kvm-userspace fails to compile

[Christoph H. <hc...@in...>]

On Tue, Jan 15, 2008 at 07:44:09PM +0200, Avi Kivity wrote:
> Yes, you're right.  My confusion arose because we have two distinct needs 
> for a "kernel directory":
>
> 1. A build directory for the external module (which really needs to be a 
> kernel directory)
> 2. A directory with the exported userspace headers (like /usr/include)
>
> We are using one directory for both.  Once we separate this, the mess 
> should be cleared up.

Exactly.  Please just bundle the latest required interface headers with
the userspace tarball.  Take e.g. xfs as an example.  This one doesn't
just need the whole filesystem layer but also quite a few lowlevel
implementation files that are used in libxfs through an kernel API shim
layer.  Instead of having some fragile dependencies it just ships copies
of the kernel files in exactly the version it needs.  Resyncing is quite
trivial and can be automated with a script.