#33 History forward and backward

closed-fixed
5
2010-09-30
2010-01-30
No

As discussed in the forum. I manually edited this diff file (because there were also other changes in there; so I hope everything is ok). Maybe not so good, because it is my first krusader patch. commented out is another possibility (as in total commander; remove current until last history entry, if from a "walked" history is gone to a new directory)

// first alternative in krusader/GUI/dirhistoryqueue.cpp)

Discussion

  • Franz Steinhaeusler

    mistake for that pacth
    AddToUrlQueue (ignore changes variable changed)
    ignore: SaveDirHistory(bool left) (that was from another patch (saving and loading history)

     
  • Franz Steinhaeusler

    if there is something unclear, please let me know.
    also that
    AddToUrlQueue is not intended for that patch here.

     
  • Franz Steinhaeusler

    • labels: --> New feature
     
  • Franz Steinhaeusler

    and in krusader/GUI/dirhistorybutton.cpp:
    if (id == historyQueue->GetCurPtrHistory())
    first = act;
    shows the clasp on the right place

     
  • Franz Steinhaeusler

    please for get all comments. I have saved my current krusader to another directory and cleaned up for that patch.
    and ran svn diff again.

    /krusader/krusader/GUI/dirhistoryqueue.cpp
    void DirHistoryQueue::slotPathChanged(ListPanel* p)
    commenated out

    I have to possibilties there:
    // first alternative: leave it, put the last one on top (the cur_ptor_history)

    that was strange in slotpathchanged
    urlQueue.push_front(KUrl (urlQueue[cur_ptr_history].prettyUrl()));
    //AddToUrlQueue((urlQueue[cur_ptr_history]); // crashes, hmm

    // second alternative: leave it, put the last one on top (the cur_ptor_history)

     
  • Franz Steinhaeusler

    I have updated my patch to krusader 18.08.2010 version.
    (in the patch there is also a replacement for
    //if (!proc.startDetached())
    // KMessageBox::sorry(krMainWindow, i18n("Can not open \"%1\"", edit));
    (this is surely not the best solution) to
    system((edit + " " + url.path() + " &").toAscii().data());
    otherwise some program don't seem to start

     
  • Franz Steinhaeusler

    Sorry, I think I forgot

    krusader/kractions.h about Line57:
    static KAction *actPopularUrls, *actLocationBar, *actJumpBack, *actSetJumpBack, *actHistoryGoForward, *actHistoryGoBackward, *actCreateChecksum, *actMatchChecksum;
    static KAction *actView0, *actView1, *actView2, *actView3, *actView4, *actView5, *actCopy, *actPaste, *actShowViewOptionsMenu;

     
  • Jan Lepper

    Jan Lepper - 2010-09-06
    • assigned_to: nobody --> jlepper
     
  • Jan Lepper

    Jan Lepper - 2010-09-06

    Hi, since I'm planning to rework some of the panel functionality, I will look at this the process.
    But there might be a lot of changes, so will probably not start with this before the coming release.

     
  • Nobody/Anonymous

    No problem. I have it implemented for about half of a year and I'm glad about it. :) I think, it is very practically. I also used if often in Total Commander.

     
  • Jan Lepper

    Jan Lepper - 2010-09-30

    I've changed my plan, and just committed my own implementation - although I drew some inspiration from yours ;-)
    I haven't implemented save/restore yet, as I want to save settings for each tab individually, and this will require some more changes.

     
  • Jan Lepper

    Jan Lepper - 2010-09-30
    • status: open --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks