[Krang-bugs] [Bug 23] krang_upgrade leaves root-owned files in htdocs

[<bug...@kr...>]

http://bugzilla.krangcms.com/show_bug.cgi?id=23





------- Comment #3 from nwe...@er...  2007-12-18 20:39 -------
Hi Dave -

Not sure if this helps but taking a quick look at krang_install vs.
krang_upgrade the only difference in their application of ownership is that 
whereas install simply recurses on everything in the installpath:

$CHOWN_BIN ." -R  --no-dereference $KrangUser\:$KrangGroup $InstallPath";

krang_upgrade does a couple extra checks:

   # skip sym-links to files that don't exist, which will choke
    # chown.  This can happen as a result of installing an older SSL
    # Krang which had links to install directory.  It'd be nice to
    # write an upgrade module to weed them out but upgrade modules
    # don't run until after the chown...
    my $chown = $CHOWN_BIN ." -R  --no-dereference $KrangUser\:$KrangGroup ";
    find({ no_chdir => 1,
           follow   => 0,
           wanted   =>
           sub {
               return if -l $_ and !-e $_; # skip bad links
               # handle files with double quotes in the name
               $_ =~ s/"/\\"/g;
               system($chown . qq| "$_"|)
                 and warn(qq/   Warning: unable to chown "$_".\n/);
           }
         }, $InstallPath);

Other than that would it have to be something failing in one of the upgrade
scripts? (Have you encountered this problem upgrading any other old versions?)

Noam


-- 
Configure bugmail: http://bugzilla.krangcms.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.