Menu

#33 fix wrong evaluation order of an expression

v1.0_(example)
open
nobody
None
5
2018-08-29
2018-08-27
No

There is a piece of code that has unpredictable results, leading to errors when running atac compiled with gcc >=7:

--- a/atac-driver/libatac/atacMatchList.C
+++ b/atac-driver/libatac/atacMatchList.C
@@ -47,5 +47,6 @@

   memcpy(&_matches[_matchesLen], &m, sizeof(atacMatch));


-  _matches[_matchesLen].matchiid = _matchesLen++;
+  _matches[_matchesLen].matchiid = _matchesLen;
+  _matchesLen++;
 }

Discussion

  • Dan Bolser

    Dan Bolser - 2018-08-28

    Thanks for looking at this Liubov. Are you actively using ATAC?

     
  • Liubov Chuprikova

    No. My goal was to provide some tests for Continuous Integration System inside Debian. But according to Debian Statistics there are some active users of ATAC and other binaries inside k-mer tools [1].

    It would be great if you prepare a new versioned release of ATAC for downloading. Thank you!

    [1] https://qa.debian.org/popcon.php?package=kmer

     

    Last edit: Liubov Chuprikova 2018-08-29

Log in to post a comment.

MongoDB Logo MongoDB