#9 Newzbin "msgid_#####_" strip

[Jesse Young]

This patch removes the appended
"msgid_#######_" string on Newzbin NZB created
directories. I always find it annoying having to
manually remove each appended tag, or forgetting
and not having my download directory looking clean.

I have only tested this lightly, but appears to be
working just fine for me.

This patch will prove to be most useful with an
automatic directory monitor for NZBs (that come from
Newzbin, of course). I saw the monitoring feature
listed in the "Feature Requests."

None the less, in short this increases my laziness of
not having to remove text from the standard NZBs I
received from Newzbin. Enjoy.

[Jesse Young]

Logged In: YES
user_id=1419706

super slick. I just came to check on this patch's status and it doesn't look
like I attached it correctly (I forgot the little check box). That's what I get
for submitting at 5:30am... :)

[Alessandro Bonometti]

Logged In: YES
user_id=523378

Thanks for the patch. From a first look, it seems there
are a few problems:
1) You sent me the "reverse diff", i.e. the diff to go
from the modified sources to the original (ok, I can use
"-R", but then...:)
2) Please use kdDebug() instead of qDebug()
3) Since stripNewzbin is only used in NzbForm, I think it
should be a (private) member of that class (now it's in
the global namespace)
4) Move the searches for "msgidstart", "underscore" inside
the if (so that the searches are done only if the dirname
contains msgid)

Can you send me a modified version?

[Jesse Young]

Logged In: YES
user_id=1419706

1. Fixed. I must have gotten mixed up on which directory I
was currently in.

2. Switched Debugs to kdDebug(), my intentions were to
remove them before submitting (note to self, no more late
night submissions)

3. Nearly have this complete. I actually had to have
stripNewzbin() in QMgr::slotAddPostItem() (line 299 I
believe). I'm having problems finding the correct place to
put the call, rather than in QMgr directly.

4. Fixed. Thanks for catching that, horrible coding on my
part.

[Jesse Young]

Logged In: YES
user_id=1419706

So, I thought I'd comment as it didn't look like I'd be able to
solve this for a few days. I got it shortly there after. I think
this patch will be much better than the original I submitted.

[Jesse Young]

Newzbin Stripping Patch - 2nd attempt

[Jesse Young]

Newzbin Stripping Patch - 3rd Revision

[Jesse Young]

Logged In: YES
user_id=1419706

3rd, and final (I hope), revision to this patch. I had left an extra call that
was no longer needed, this has been removed. Further clean up of
function, variables and assignments moved within `if` block.