Re: [kln2-devel] Solfeggio notation implementation checked in to CVS

[Marek W. <Mar...@fu...>]

On Sunday 11 April 2004 08:56, Fernando Cuenca wrote:
> The first stage of the implementation of the Solfeggio
> notation is checked in.

Thanks! It does work. :) And it is a really neat (and well
commented :) piece of code, too.

> Unfortunatelly, there isn't much you will see, since I
> haven't changed the GUI

Just for e-body to see, I've committed a slightly changed code:
the Solfeggio is hard-coded as a default if someone exited kln2
with German notation selected (English stays English) - this way
anyone can see all the Do/Re/Mi stuff at a startup. But when a
user switches to the English/German notations, for now there is
no way to switch back to Solfeggio. E-body, note: names on buttons,
notes' highlight names, names of lessons (in the lessons combo),
comp. keyboard input, changing a clef...

Fernando, I understand, you are working on changing
English/German toggle action to a multiple choice menu item now,
right? :)

> > The problem is the following:
> > in KLearnNotes2::setClefByAction() midi pitches are setup.

I believe this was a problem for old widgets only. The new one
(PianoKeyboard and new NameButtonsBox) deal with notes through
BaseMusicNote and should handle changing of notes naming
convention a bit differently (coded only partially).

Anyway, as I don't know if you can hear midi sounds I corrected
this myself (and already committed changes). This part of code
relied on specific note's name. I changed it to rely on note's
pitch (and its number in in its octave). I also corrected
buttons' clicking slots [to run checkanswer() with a proper
arguments].

It works really smoothly. :)
Regards,
Marek

PS:
On Sunday 11 April 2004 08:56, Fernando Cuenca wrote:
> -- [...] <Marek.Wieckowski@fuw[GRRR]> wrote:

The kln2-devel mailing list is archived and available through
WWW. Therefore, to reduce spamming possibilities, please, try to
avoid citing full e-mail addresses in an open text in an e-mail
body when replying. M.

-- 

     \/   /|\  Marek Wieckowski
  #####  | | |
 = . . =  \|/  Institute of Theoretical Physics
    U      |   Warsaw University
  / ~ \___ |
 <|   |    |
  > . <    |   http://www.fuw.edu.pl/~wiecko
 <<___>>   |   http://klearnnotes2.sourceforge.net