[kln2-devel] Solfeggio notation implementation checked in to CVS

[Fernando C. <fer...@ya...>]

Hi all,

The first stage of the implementation of the Solfeggio notation is checked
in. Unfortunatelly, there isn't much you will see, since I haven't changed
the GUI so you can actually select the Solfeggio notation, but believe me
that the required infrastructure is already there! :-)

The main thing to note is that the orderOfNotes array is gone, and replace
by a ScaleNotation object, which you can obtain by calling the getNotation
static function  in the BaseMusicNote class. The ScaleNotation class is
designed to be somewhat backward-compatible with the array.

Now, some comments on a previous e-mail from Marek:

--- Marek Wieckowski <Mar...@fu...> wrote:
> The problem is the following:
> in KLearnNotes2::setClefByAction() midi pitches are setup.
> Whenever a user changes a clef, the pitch for the note just
> above the five staff lines is set (that is G for treble
> clef, B for bass clef). Now, starting from this one other
> notes' pitches are set up in steps of +2 or -2 semitones. The
> only difference is E-F and B-C = one semitone. Now in Solfeggio
> one-char notes' names changed, and this part of code does not
> recognize, that there should be one semitone difference. The
> simplest solution would be adding another 'if' : 'T' (ti) and
> 'M'(mi) for going up. 'F' for going down works even now, but
> ... 'D' (do) for going down would get confused with 'D' in
> English/German notation. Therefore this code will have to be
> current-scale-notation aware.

I'm not sure what you are refering to here, or how that function works,
but it doesn't seem to be dependant on the current notation. Maybe the
implementation changed since the time of that e-mail (I just updated my
environment yesterday).
 
> * correct the compilation problems [...related to strndup...]

I reimplemented the class in terms of QString, to avoid all those
GNU-specific functions.

Saludos!
Fernando.


__________________________________
Do you Yahoo!?
Yahoo! Tax Center - File online by April 15th
http://taxes.yahoo.com/filing.html