klearnnotes2-devel

[kln2-devel] preferences

[Carlo <si...@bl...>]

Hi,
I committed the changes on MIDI setup dialog. The dialog is quite slow
to update since the layout is edited after starting the new midiOutput
(wich takes time). But it seems to work.
Maybe an "Advanced Options" button that displays another dialog
implemented in the midiOutput would have been better. The same button
could be used for other output ways. Is it needed?


About config:
preferences-0.2 seems to run and to be easy to use, but it comes with a
custom license wich states that the copyright notice included in the
file must be included in the documentation et cetera. (btw by including
it I think we double the number of [TODO]/[FIXME] statements in kln2
source :P)
Just tell me what to do with the license and I'll implement it next
week. (usually I'm optimist with scheduling so... you've been warned :)


regards,
Carlo

[a handy copy of preferences' license:]

Redistribution and use in source and binary forms, with or without
  modification, are permitted provided that the following conditions are
met:

  1. Redistributions of source code must retain the above copyright
notice, this
  list of conditions and the following disclaimer.

  2. Redistributions in binary form must reproduce the above copyright
notice,
  this list of conditions and the following disclaimer in the
documentation
  and/or other materials provided with the distribution.

  3. Neither name of the copyright holders nor the names of its
contributors may
  be used to endorse or promote products derived from this software
without
  specific prior written permission.

  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
``AS IS''
  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
THE
  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE
  DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
LIABLE
  FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL
  DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
GOODS OR
  SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER
  CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY,
  OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
THE USE
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Re: [kln2-devel] preferences

[Marek W. <Mar...@fu...>]

On Thu, 19 Aug 2004, Carlo wrote:
> I committed the changes on MIDI setup dialog.
[...]
> About config:
> it comes with a custom license

Carlo,

I don't have an easy computer access right now. I'll look at this next
week. Sorry.

> (wich takes time).
> Maybe an "Advanced Options" button

Pitch input config will have the same problem. Probably some way of
signalling that re-config is in progress will be needed. Maybe a
sand-glass coursor? For now I suppose it can stay the way it is. :)

Anyway, thanks again for your commits.

Regards,
Marek

-- 

     \/   /|\  Marek Wieckowski
  #####  | | |
 = . . =  \|/  Institute of Theoretical Physics
    U      |   Warsaw University
  / ~ \___ |
 <|   |    |
  > . <    |   http://www.fuw.edu.pl/~wiecko
 <<___>>   |   http://klearnnotes2.sourceforge.net

Re: [kln2-devel] preferences

[Marek W. <Mar...@fu...>]

On Thu, 19 Aug 2004, Carlo wrote:
> About config:
> preferences-0.2 seems to run and to be easy to use, but it comes with a
> custom license

Carlo,
The license seems more or less OK. But, true: it's not GPL.

I've just sent an e-mail to David Johnson - the author of
preferences-2.0 - asking him to GPL it. But I'm sure, that even
if he doesn't GPL the code we can use it - we'll just have to
add the license file to the source (which may be quite tricky
once the original David's code is modified).

> Just tell me what to do with the license and I'll implement it next
> week. (usually I'm optimist with scheduling so... you've been warned :)

Anyway, yeah: if you find some time, please code kln2 settings
using the preferences-2.0. The license allows modifying the
source, so change whatever you need to. I'll take care of adding
the license info etc. depending on David's answer.

Regards,
Marek

-- 

     \/   /|\  Marek Wieckowski
  #####  | | |
 = . . =  \|/  Institute of Theoretical Physics
    U      |   Warsaw University
  / ~ \___ |
 <|   |    |
  > . <    |   http://www.fuw.edu.pl/~wiecko
 <<___>>   |   http://klearnnotes2.sourceforge.net

Re: [kln2-devel] preferences

[Marek W. <Mar...@fu...>]

Hi e-body,

On Thu, 19 Aug 2004, Carlo wrote:
> preferences-0.2 seems to run and to be easy to use, but it comes with a
> custom license

I have received an answer from David Johnson (see below). His
license appears not to be his "custom license" - it is a
standard "modified BSD license". :) And is perfectly compatible
with GPL.

I don't like the last David's suggestion though - if he wanted
it to be non-copylefted it should stay like this (the modified
files should be left with the modified BSD license, not GPL-ed).
Carlo, my suggestion is:
1) if there are any big additions to be made which are kind of
 stand-alone - write them to a separate file;
2) but don't hesitate to modify the David's files as much as
 you have to;
3) leave his license and copyright in .h plus add a line like:
 // Modified by Carlo Vanini for KLearnNotes2.
 (cf. my remarks in cvoicecontrolkln2.c)

Happy coding! :) If I can be of any help just let me know.
~Marek

PS. But we cannot learn by heart all the GPL compatible
licenses... :( I'm not sure how to avoid a similar confusion in
the future.

---------- Forwarded message ----------
Date: Mon, 30 Aug 2004 19:46:20 -0700
From: David Johnson <david AT usermode...>
To: Marek Wieckowski <Marek.Wieckowski AT fuw...>
Subject: Re: preferences-2.0 license

On Monday 30 August 2004 10:57 am, you wrote:

> We would like to use your preferences-2.0 for storing user
> preferences. It seems really promising especially compared to
> what we used so far. I'm writing this e-mail to ask you to allow
> us to use this code under terms of GNU General Public License,
> rather than your "list of conditions".

My Preferences class is licensed under the "three clause" BSD License.
This license is fully compatible with the GNU GPL. You are already free
to use the code in GPL licensed products, and it will not affect your
own license!

Richard Stallman has declared the license I use to be fully compatible
with the GPL. Please see
<http://www.gnu.org/licenses/license-list.html#ModifiedBSD>. This means
you may distribute my Preferences class or derivatives you make of it
under the terms and licensing of the GPL.

> Your license says: "Redistribution and use in source [...] with
> [...] modification, are permitted ...". Yes, to make your code
> useful for us it will have to be modified. But if we modify the
> file it is not clear to what the original license applies to!

The license is clear. My terms apply to the modified source code! You
cannot remove my copyright or license statements. However, you are
permitted to add to them with the terms of the GPL. It does not matter
to me if you keep do or do not keep track of specific modifications in
the source files. Merely keeping the copryight and license statements
at the top is sufficient. If you distribute the code under the terms of
the GPL, then you are also distributing it under my terms, so there is
no problem.

What some GPL projects have done with BSD licensed code is to include
the standard GPL notice, followed by a statement that the original code
was copyrighted by the author under the listed BSD terms.

Does this make sense? If it does not, please let me know.

-- 
David Johnson
___________________
http://www.usermode.org

[kln2-devel] midi setup dialog

[Marek W. <Mar...@fu...>]

Hi e-body,

On Thu, 19 Aug 2004, Carlo wrote:
> I committed the changes on MIDI setup dialog. The dialog is quite slow
> to update

Just two small changes.

1) midi_setup.cpp:
setHidden() is not a part of the old Qt 3.0.2. Because all other
parts of kln2 compile with these libs I added a wrapper for this
- not a nice one, but it seems to work.

The wrapper uses isVisible() instead of isHidden(). It wouldn't work
if the dialog was prepared before it is shown, but here this is not the
case - changes in the dialog looks happen when it is visible.

2) I added a globalcursor.h file for a WaitCursor - you can see it
work when you change midi system in midi_setup dialog.

Ciao,
Marek

-- 

     \/   /|\  Marek Wieckowski
  #####  | | |
 = . . =  \|/  Institute of Theoretical Physics
    U      |   Warsaw University
  / ~ \___ |
 <|   |    |
  > . <    |   http://www.fuw.edu.pl/~wiecko
 <<___>>   |   http://klearnnotes2.sourceforge.net