Bugs found on 1.11 and 1.12 patch

[Sasuke Uchiwa]

Hello, i'm working since a moment to the sources of Falcon KMS 1.10 for have pictures of Tech 2 items and Ships Tech 2, and for have all drones pictures T1 and T2 when we watch the kill

With the new patch i saw somes bugs :

Bugs about noImage.png for somes php sources
Dont work fro directory : People and Images

- File : showmail.php

     Line 57 find : else {$fileName = "people/noImage.png";}
     Replace by : else {$fileName = "people/999.png";}

- File : frontendfunctions.php

     Line 522 find : $ImageID = "noImage";
     Replace by : $ImageID = "999";

- File : frontend.php

     Line 223 find: else { $fileName = "people/noImage.png"; }   
     Replace by : else { $fileName = "people/999.png"; }

Bug about Corporation picture when we look Corporation stats.

- File frontendfunctions.php

     Line 573 find : $filename = "corp/" . $PlayerID . ".png";
     Replace by : $filename = "corp/" . $CorpID . ".png";

Bug with php code IGB, when try to add new killmail
A function is declared twice

- File : igb.php

     Line 154 find : include "functions.php";
     Replace by : include_once "functions.php";

- File : parser.php

     Line 10 find : include "functions.php";
     Replace by : include_once "functions.php";

Bug with : "'" when you add new Killmail on DB, when you use Show Original Killmail, there is an incorrect killmail

- File parser.php

     Line 115 find : $parsedMail = addslashes($_POST['textarea']);
     Replace by : $parsedMail = $_POST['textarea'];

I know there is a post talking about bug with : "'" and ask to add : addslashes
I duno why we need add : addslashed, i never got problems with "'" in killmail, but since you add : addslashes on 1.11 and 1.12, original killmail become invalid

For people when use new version 1.11 and 1.12 with older Database with all killmail

- File : originalmail.php

     Line 31 find : $uncompressedData = gzuncompress($killMail[8]);
     Replace by : $uncompressedData = $killMail[8];

Bugs on function for recalculates all points
Wrongs results after use function

- File : recalculate_points.php

     Line 48 find : $sql = "UPDATE `Player` SET `KillPoints` = '$totalPoints' WHERE `PlayerID` = $allPlayers[0]";
     Replace by : $sql = "UPDATE `Player` SET `KillPoints` = '$TotalPoints' , `NetPoints` = '$TotalPoints' WHERE `PlayerID` = $AllPlayers[0]";

     Line 76 find : $sql = "UPDATE `Player` SET `LossPoints` = '$totalPoints' WHERE `PlayerID` = $allPlayers[0]";
     Replace by : $sql = "UPDATE `Player` SET `LossPoints` = '$TotalPoints' , `NetPoints` = `NetPoints` - '$TotalPoints' WHERE `PlayerID` = $AllPlayers[0]";

     Line 85 find : /*$sql = "SELECT * FROM `Corp`";
     Replace by : $sql = "SELECT * FROM `Corp`";

     Line 135 find : }*/
     Replace by : }

Oki now, i think it's all, i hope you can see modif and if you can add new version with new corrections for all users

I would like to send my sources but too many modifs on sources and on database for T2 items and ships with drones pictures

[Geoffrey Wilson]

recalculate_points.php isn't supposed to be included with the release, I will remove it from 1.13, otherwise thanks for the fixes, they will be implemented in the next version.

[Sasuke Uchiwa]

Hello geoffw22

First, great job for your killboard :)

After i think for clean sources, better keep using noImage.png than 999.png

So just need rename file "999.png" to "noImage.png" from "Corp", "Images", "People" directory

- File frontendfunctions.php

     Line 152 find : $imageID = "999";
     Replace by : $imageID = "noImage";

     Line 578 find : $imageID = "999";
     Replace by : $imageID = "noImage";

     Line 634 find : $imageID = "999";
     Replace by : $imageID = "noImage";

__________________________________________________________________________

I could got somes infos about the bug with "'" and know why i never got this problem on my own killboard without addslashes()
Infos from php.net :

The PHP directive  magic_quotes_gpc is on by default, and it essentially runs addslashes() on all GET, POST, and COOKIE data. Do not use addslashes() on strings that have already been escaped with magic_quotes_gpc as you'll then do double escaping. The function get_magic_quotes_gpc() may come in handy for checking this

my magic_quotes_gpc is on by default

__________________________________________________________________________

Last thing, you said recalculate_points.php isn't suppoed to be included with the release.

I duno if others play often with database, but with somes bugs i got with addslashes i needed to delete somes killmails and insert back again

recalculate_points.php help me for have correctly scores :)

Regards,