Re: [Kile-devel] Review Request 111019: fix for angle/width specification in includegraphics

[Michel L. <mic...@gm...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111019/#review46178
-----------------------------------------------------------


Sorry, but I don't agree. I don't think that specifying either size or rotation first is more natural than doing it the other way around.

Still, the include-graphics-dialog could be improved in the sense that it's not clear at the moment which order is imposed... Do you maybe have any ideas regarding that?

- Michel Ludwig


On June 14, 2013, 11:41 a.m., Yngve Inntjore Levinsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111019/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 11:41 a.m.)
> 
> 
> Review request for Kile and Michel Ludwig.
> 
> 
> Repository: kile
> 
> 
> Description
> -------
> 
> When both angle and width/height are specified in the includegraphics window, I would think it is more natural to define the rotation before the resizing. Please also see thread here: http://sourceforge.net/mailarchive/message.php?msg_id=31055395
> 
> 
> Diffs
> -----
> 
>   src/dialogs/includegraphicsdialog.cpp c1d0abb 
> 
> Diff: https://git.reviewboard.kde.org/r/111019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yngve Inntjore Levinsen
> 
>