From: Michel L. <mic...@gm...> - 2012-09-08 08:10:58
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106363/#review18679 ----------------------------------------------------------- Thanks! I'd also suggest to give the user the power to override our bib tool detection by adding a new entry to the "Build" menu with a submenu that would allow to choose between "auto-detect", "BibTeX", or "Biblatex" (similar to the "Live Preview" entry). The chosen settings could then be stored in LaTeXOutputHandler as well (which might also need a new name now as it refers to pre-compilation settings as well then :) src/documentinfo.h <http://git.reviewboard.kde.org/r/106363/#comment14762> Could you leave the methods 'public' here? src/outputinfo.h <http://git.reviewboard.kde.org/r/106363/#comment14763> Just to keep the naming convention: writeBibliographyBack... -> setBibliographyBackendToolName readBibliographyBack... -> bibliographyBackendToolName() - Michel Ludwig On Sept. 7, 2012, 10:14 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106363/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 10:14 p.m.) > > > Review request for Kile. > > > Description > ------- > > As we can detect what backend is used by Biblatex only when it prints it out, we need to store that information for next updates of bibliography > > This patch use dirty approach: it just stores this as dynamic property of TextInfo object and uses it afterwards. I believe we must store this information somewhere or parse \usepackage{biblatex}. > Maybe in the future Biblatex will provide some other setup commands for specifiyng backend which will be needed to parse also. > I understand, that dynamic property is not the best place to store it. From the other hand, it is kind of local information in this approach, because property name is not used outside. > > > This addresses bug 268047. > http://bugs.kde.org/show_bug.cgi?id=268047 > > > Diffs > ----- > > src/documentinfo.h 27ad09f > src/documentinfo.cpp 2c3a3bb > src/kileproject.h e77035a > src/kileproject.cpp dd4087d > src/kilestdtools.cpp 0c6e5f0 > src/outputinfo.h 096c708 > src/outputinfo.cpp 8d18adc > > Diff: http://git.reviewboard.kde.org/r/106363/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Eugene Shalygin > > |