From: Michel L. <mic...@gm...> - 2012-09-07 20:58:56
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106363/#review18672 ----------------------------------------------------------- Thanks, but actually 'LaTeXOutputHandler' could be used for storing information that results from compilation attempts. 'LaTeXInfo' and 'KileProject' both inherit 'LaTeXOutputHandler', i.e. the LaTeX tool will always have a pointer to the right object (either a simple document or a project depending on what is being compiled). So, you could add methods to LaTeXOutputHandler that would record which bibliography tool was run last. However, I'm not sure that this is the right fix. Kile tries to run BibTeX as the timestamp of the .bbl has changed (probably due to Biblatex rewriting it) and 'updateBibs' returns true. But at the same time, LaTeX didn't print a message saying that biber would have to be rerun. So, wouldn't it be easier to simply rely on these message if Biblatex is used, i.e. in this case nothing printed and we don't run _any_ bibliography tool? - Michel Ludwig On Sept. 7, 2012, 7:38 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106363/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 7:38 p.m.) > > > Review request for Kile. > > > Description > ------- > > As we can detect what backend is used by Biblatex only when it prints it out, we need to store that information for next updates of bibliography > > This patch use dirty approach: it just stores this as dynamic property of TextInfo object and uses it afterwards. I believe we must store this information somewhere or parse \usepackage{biblatex}. > Maybe in the future Biblatex will provide some other setup commands for specifiyng backend which will be needed to parse also. > I understand, that dynamic property is not the best place to store it. From the other hand, it is kind of local information in this approach, because property name is not used outside. > > > This addresses bug 268047. > http://bugs.kde.org/show_bug.cgi?id=268047 > > > Diffs > ----- > > src/kilestdtools.cpp 0c6e5f0 > > Diff: http://git.reviewboard.kde.org/r/106363/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Eugene Shalygin > > |